Skip to content

Demo - remove redundant accessibility exceptions #35511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flagmanAndrew merged 5 commits into from
Oct 7, 2026
Merged

Demo - remove redundant accessibility exceptions #35511

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
343dd2c
aria label filter editor
flagmanAndrew Oct 6, 2026
82f6605
del redundant rules
flagmanAndrew Oct 6, 2026
37f45bd
filter-row specific attr
flagmanAndrew Oct 6, 2026
a759137
del globalize accessibility exception
flagmanAndrew Oct 6, 2026
6d433cf
rollback onEditorPreparing
flagmanAndrew Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/demos/Demos/Localization/UsingGlobalize/Angular/app/app.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
format="currency"
[editorOptions]="{
format: 'currency',
showClearButton: true
showClearButton: true,
inputAttr: { 'aria-label': 'Filter cell' }
}"
>
</dxi-data-grid-column>
Expand Down
3 changes: 3 additions & 0 deletions apps/demos/Demos/Localization/UsingGlobalize/React/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ const editPopupOptions = {
const amountEditorOptions = {
format: 'currency',
showClearButton: true,
inputAttr: {
'aria-label': 'Filter cell',
},
Comment thread
Copilot marked this conversation as resolved.
Outdated
};
const selectBoxInputAttr = { id: 'selectInput' };

Expand Down
3 changes: 3 additions & 0 deletions apps/demos/Demos/Localization/UsingGlobalize/ReactJs/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ const editPopupOptions = {
const amountEditorOptions = {
format: 'currency',
showClearButton: true,
inputAttr: {
'aria-label': 'Filter cell',
},
};
const selectBoxInputAttr = { id: 'selectInput' };
Globalize.load(deCldrData, ruCldrData, supplementalCldrData);
Expand Down
8 changes: 7 additions & 1 deletion apps/demos/Demos/Localization/UsingGlobalize/Vue/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,13 @@ const locales: { Name: string, Value: Locale }[] = service.getLocales();
const payments: Record<string, string | number>[] = service.getPayments();
const locale: Locale = getLocale();
const editPopupOptions = { width: 700, height: 345 };
const amountEditorOptions = { format: 'currency', showClearButton: true };
const amountEditorOptions = {
format: 'currency',
showClearButton: true,
inputAttr: {
'aria-label': 'Filter cell',
},
};
const selectBoxInputAttr = { id: 'selectInput' };
const formatMessage = ref((msg: string) => msg);

Expand Down
3 changes: 3 additions & 0 deletions apps/demos/Demos/Localization/UsingGlobalize/jQuery/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ $(() => {
editorOptions: {
format: 'currency',
showClearButton: true,
inputAttr: {
'aria-label': 'Filter cell',
},
},
}, {
dataField: 'PaymentDate',
Expand Down
3 changes: 0 additions & 3 deletions apps/demos/testing/common.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ const getIgnoredRules = (testName) => {
}

const specificRules = {
'DataGrid-EditStateManagement': ['aria-required-parent'],
'DataGrid-RemoteCRUDOperations': ['scrollable-region-focusable'],

'Diagram-Adaptability': ['aria-dialog-name', 'label'],
'Diagram-AdvancedDataBinding': ['aria-dialog-name', 'label'],
'Diagram-Containers': ['aria-dialog-name', 'label'],
Expand Down
Loading