Repository navigation
CMake: Boost CONFIG Mode - #64
Merged
Merged
Conversation
This was referenced Sep 23, 2026
Find Boost via its own CMake config package (`BoostConfig.cmake`) instead of CMake's deprecated `FindBoost` module, which warns with CMake 3.30+ (policy CMP0167). - require Boost 1.71+ (first `BoostConfig.cmake` in 1.70 has known issues, fixed in 1.71) - link `Boost::headers` - tests: set `BOOST_TEST_DYN_LINK` if `Boost::unit_test_framework` is a shared library; removes the `PXRMP_BOOST_TEST_DYN_LINK` option, which was never used (tests checked `PXRMP_BOOST_TEST_DYN`) - document the requirement in the README Close ECP-WarpX#55 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ax3l
force-pushed
the
topic-boost-config
branch
from
September 23, 2026 17:45
2e0437c to
8d61231
Compare
ax3l
commented
Sep 23, 2026
ax3l
commented
Sep 23, 2026
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
lucafedeli88
approved these changes
Sep 24, 2026
lucafedeli88
left a comment
lucafedeli88
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks a lot , @ax3l
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find Boost via its own
BoostConfig.cmakeinstead of CMake'sFindBoostmodule.FindBoosttriggers a CMP0167 warning with CMake 3.30+.Close #55
Boost::headers.BOOST_TEST_DYN_LINKautomatically when Boost.Test is a shared library. ThePXRMP_BOOST_TEST_DYN_LINKoption never took effect, so it is removed.Breaks: setups without
BoostConfig.cmake, such as conda-forgelibboost-headersalone (uselibboost-devel, see BLAST-WarpX/warpx#7296) and RHEL 8/9 system Boost.Tested: CMake 3.31.6 and Boost 1.85. No warnings with
-Werror=dev, and all tests pass.Follow-ups:
Boost_ROOT#57 (CMP0144) is not addressed here.