Load full ChangeNow currency list to resolve delisted assets - #221
Open
paullinator wants to merge 1 commit into
Open
Load full ChangeNow currency list to resolve delisted assets#221paullinator wants to merge 1 commit into
paullinator wants to merge 1 commit into
Conversation
The currency cache was built from the `currencies?active=true` endpoint. When ChangeNow deactivates an asset (e.g. DASH), it disappears from the active list while historical transactions still reference it. The lookup then misses and the plugin halts fail-closed, stalling all ChangeNow transaction collection. Fetch the full currency list (omit `active=true`) so previously-listed assets continue to resolve for historical transactions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currency cache was built from the
currencies?active=trueendpoint. When ChangeNow deactivates an asset (e.g. DASH), it disappears from the active list while historical transactions still reference it. The lookup then misses and the plugin halts fail-closed, stalling all ChangeNow transaction collection.Fetch the full currency list (omit
active=true) so previously-listed assets continue to resolve for historical transactions.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Low Risk
Single URL/query change in currency cache loading with no auth or schema changes; slightly larger cache payload is the main tradeoff.
Overview
ChangeNow currency cache no longer filters to
active=truewhen callingexchange/currencies. The plugin now loads the full currency list so tickers that ChangeNow has deactivated (e.g. DASH) still resolve when processing historical swaps.Previously, a cache miss in
getAssetInfothrew and stopped collection fail-closed for otherwise valid past transactions. Comments inloadCurrencyCachedocument that behavior.Reviewed by Cursor Bugbot for commit f3cd90d. Bugbot is set up for automated code reviews on this repo. Configure here.