Skip to content

Load full ChangeNow currency list to resolve delisted assets #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paullinator wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Load full ChangeNow currency list to resolve delisted assets #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/partners/changenow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,12 @@ async function loadCurrencyCache(
}

try {
// The exchange/currencies endpoint doesn't require authentication
const url = 'https://api.changenow.io/v2/exchange/currencies?active=true'
// The exchange/currencies endpoint doesn't require authentication.
// Fetch the full list (omit `active=true`): historical transactions can
// reference currencies that ChangeNow has since deactivated/delisted (e.g.
// DASH). Filtering to active-only drops those entries, causing a cache miss
// and a fail-closed halt on otherwise-valid historical transactions.
const url = 'https://api.changenow.io/v2/exchange/currencies'
const response = await retryFetch(url, {
method: 'GET'
})
Expand Down
Loading