Repository navigation
Conversation
c3024
marked this pull request as ready for review
November 13, 2026 07:50
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
November 13, 2026 07:50
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Sends the new
userMetadata.nudgedDatefrom Auth PR 26516 to FullStory asnudged_date. It is the date the user was nudged to NewDot, so we can tell which users were already on Expensify before NewDot. The date is converted toDatelikenps_response_date. Web declares it as adatein thesetPropertiesschema and native adds the_datesuffix, so FullStory types it as a date on both. Only nudged users have the field, so nothing is sent for anyone else.Fixed Issues
$ #103321
PROPOSAL: N/A
Tests
npm test -- tests/unit/FullstoryUtilsTest.ts.nudged_dateis built fromuserMetadata.nudgedDate.Offline tests
N/A. No network behavior changes.
QA Steps
FullStory only runs on production, so this can't be tested on staging.
nudged_dateis set.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A, no UI change.
Android: mWeb Chrome
N/A, no UI change.
iOS: Native
N/A, no UI change.
iOS: mWeb Safari
N/A, no UI change.
MacOS: Chrome / Safari
N/A, no UI change.