Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libs/Fullstory/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ const FS: Fullstory = {
properties: {
// eslint-disable-next-line @typescript-eslint/naming-convention -- FullStory schema uses external snake_case keys.
nps_response_date: 'date',
// eslint-disable-next-line @typescript-eslint/naming-convention -- FullStory schema uses external snake_case keys.
nudged_date: 'date',
},
},
});
Expand Down
1 change: 1 addition & 0 deletions src/libs/Fullstory/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type FullstoryUserVars = {
paid_member?: boolean;
nps_score?: number;
nps_response_date?: Date;
nudged_date?: Date;
auth_method?: 'email' | 'google' | 'apple';
reg_method?: 'Google signup' | 'email/phone signup';
login_status?: 'success' | 'failure';
Expand Down
5 changes: 4 additions & 1 deletion src/libs/Fullstory/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ function buildFullstoryUserVars({
paid_member: userMetadata?.paidMember,
nps_score: userMetadata?.npsScore,
nps_response_date: getUTCDate(userMetadata?.npsResponseDate),
nudged_date: getUTCDate(userMetadata?.nudgedDate),
} satisfies FullstoryUserVars,
(_key, value) => value !== undefined,
);
Expand All @@ -228,16 +229,18 @@ function buildPageViewedEvent(screenName: string, currentPath: string, entryPoin
}

/* eslint-disable @typescript-eslint/naming-convention -- The comparable snapshot preserves FullStory's external snake_case field names. */
type ComparableFullstoryUserVars = Omit<FullstoryUserVars, 'free_trial_end_date' | 'nps_response_date'> & {
type ComparableFullstoryUserVars = Omit<FullstoryUserVars, 'free_trial_end_date' | 'nps_response_date' | 'nudged_date'> & {
free_trial_end_date?: string;
nps_response_date?: string;
nudged_date?: string;
};

function getComparableFullstoryUserVars(userVars: FullstoryUserVars): ComparableFullstoryUserVars {
return {
...userVars,
free_trial_end_date: userVars.free_trial_end_date?.toISOString(),
nps_response_date: userVars.nps_response_date?.toISOString(),
nudged_date: userVars.nudged_date?.toISOString(),
};
}
/* eslint-enable @typescript-eslint/naming-convention */
Expand Down
3 changes: 3 additions & 0 deletions src/types/onyx/UserMetadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ type UserMetadata = {

/** When the user gave their most recent NPS score, in ISO 8601 */
npsResponseDate?: string;

/** When the user was nudged to New Expensify, as a UTC `YYYY-MM-DD HH:MM:SS` timestamp. Only set for nudged users */
nudgedDate?: string;
};

export default UserMetadata;
2 changes: 2 additions & 0 deletions tests/unit/FullstoryUtilsTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ describe('FullstoryUtils', () => {
paidMember: true,
npsScore: 9,
npsResponseDate: '2026-05-03 09:30:00',
nudgedDate: '2026-06-16 10:26:36',
},
});

Expand All @@ -64,6 +65,7 @@ describe('FullstoryUtils', () => {
expect(userVars.days_till_trial_end).toBeGreaterThan(0);
expect(userVars.free_trial_end_date?.toISOString()).toBe('2099-05-31T23:59:59.000Z');
expect(userVars.nps_response_date?.toISOString()).toBe('2026-05-03T09:30:00.000Z');
expect(userVars.nudged_date?.toISOString()).toBe('2026-06-16T10:26:36.000Z');
});

it('builds page viewed event metadata', () => {
Expand Down
Loading