Skip to content

Removed deprecated Envoy runtime guard#937

Draft
gopkarthik wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
gopkarthik:fix-qual-failures
Draft

Removed deprecated Envoy runtime guard#937
gopkarthik wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
gopkarthik:fix-qual-failures

Conversation

@gopkarthik

@gopkarthik gopkarthik commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Runtime guard was removed in envoyproxy/envoy#30446.

@google-oss-prow

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gopkarthik

Copy link
Copy Markdown
Contributor Author

/test all

@google-oss-prow

Copy link
Copy Markdown

@gopkarthik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ESPv2-presubmit-tsan 154ed1d link true /test ESPv2-presubmit-tsan
ESPv2-cloud-run-e2e-cloud-function-http-bookstore 154ed1d link true /test ESPv2-cloud-run-e2e-cloud-function-http-bookstore
ESPv2-presubmit-asan 154ed1d link true /test ESPv2-presubmit-asan
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore 154ed1d link true /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shuoyang2016 shuoyang2016 self-requested a review November 15, 2024 17:17
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gopkarthik, shuoyang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skjolber

skjolber commented Sep 1, 2025

Copy link
Copy Markdown

Unintentionally duplicated in #970

Not sure how removing config for a dead feature could break the tests, maybe it is time to try again @guoyilin42 / @shuoyang2016 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants