Skip to content

Removed deprecated Envoy runtime guard #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gopkarthik wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removed deprecated Envoy runtime guard #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Try to match it with the one in source/extensions and comment out unneeded extensions.

ENVOY_SHA1 = "349011c2ebd40f070510e34f4605bff1da64fb0e" # v1.30.7

ENVOY_SHA256 = "fee4d8c1005cac9a241e29d51a903b1b369515a8a77e5b7fe320520ae7c7b855"

http_archive(
Expand Down
1 change: 0 additions & 1 deletion examples/auth/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
1 change: 0 additions & 1 deletion examples/dynamic_routing/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
1 change: 0 additions & 1 deletion examples/grpc_dynamic_routing/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
1 change: 0 additions & 1 deletion examples/service_control/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
1 change: 0 additions & 1 deletion examples/testdata/route_match/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
1 change: 0 additions & 1 deletion examples/testdata/sidecar_backend/envoy_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle": 1,
"re2.max_program_size.error_level": 1000
}
Expand Down
6 changes: 2 additions & 4 deletions src/go/bootstrap/ads/bootstrap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ func TestCreateBootstrapConfig(t *testing.T) {
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle":1,
"http.max_requests_per_io_cycle":1,
"re2.max_program_size.error_level":1000
}
}
Expand Down Expand Up @@ -172,8 +171,7 @@ func TestCreateBootstrapConfig(t *testing.T) {
{
"name": "static-runtime",
"staticLayer": {
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": false,
"http.max_requests_per_io_cycle":1,
"http.max_requests_per_io_cycle":1,
"re2.max_program_size.error_level":1000
}
}
Expand Down
9 changes: 0 additions & 9 deletions src/go/bootstrap/layer_runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,6 @@ func CreateLayeredRuntime() *bootstrappb.LayeredRuntime {
NumberValue: 1000,
},
},
// Our service control filter may call route() in log time
// but it is possible that the route isn't set with early local reply,
// which triggers an ENVOY_BUG, so we use this flag to workaround.
// For more context, see https://github.com/envoyproxy/envoy/issues/28626.
"envoy.reloadable_features.prohibit_route_refresh_after_response_headers_sent": {
Kind: &structpb.Value_BoolValue{
BoolValue: false,
},
},
// Enable an Envoy vulnerability mitigation. For details, please see b/299661830.
"http.max_requests_per_io_cycle": {
Kind: &structpb.Value_NumberValue{
Expand Down
Empty file added tests/env/testdata/access_log.txt
View file
Open in desktop
Empty file.