sync installed_as_dependency when changing installed_on_request

[ooye-sanket]

When marking a formula as not installed on request, also set
installed_as_dependency to true, to ensure brew bundle dump
correctly excludes it.

Previously, brew tab --no-installed-on-request had no effect on
brew bundle dump because the dump logic in brew.rb checks both fields:

f[:installed_on_request?] || !f[:installed_as_dependency?]

Setting installed_on_request to false alone was not enough if
installed_as_dependency was also false — the second condition would
still evaluate to true, causing the formula to be included in the dump.

Fixes #21751

@MikeMcQuaid can you please review it!!

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

---

• AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

---

[MikeMcQuaid]

@ooye-sanket thanks for the PR! I actually think the bigger change we should make is get rid of installed_as_dependency altogether; replace all call sites with installed_on_request and stop storing it in new Tabs for both formulae and casks.

[ooye-sanket]

Thanks @MikeMcQuaid!

I'd love to take on the bigger refactor. Before I start, could you clarify the approach?

• Should installed_on_request become the single source of truth (i.e., !installed_on_request replaces every installed_as_dependency check)?
• Should we keep reading the old installed_as_dependency from existing tab JSON files for backward compatibility, or drop that as well?
• Should this be a separate PR from the current one, or should I update this PR?

[MikeMcQuaid]

• Should installed_on_request become the single source of truth (i.e., !installed_on_request replaces every installed_as_dependency check)?

Yep!

• Should we keep reading the old installed_as_dependency from existing tab JSON files for backward compatibility, or drop that as well?

No, think we can skip/drop that too.

• Should this be a separate PR from the current one, or should I update this PR?

Can update this PR!

[ooye-sanket]

Hi @MikeMcQuaid, I've updated the PR with the full refactor as you suggested!

Here's what was done:

• Removed installed_as_dependency entirely from AbstractTab and Tab (no longer stored in new tab JSON files)
• Replaced all call sites with !installed_on_request installed_on_request is now the single source of truth
• Updated formula_installer.rb, cask/installer.rb, install.rb, reinstall.rb, upgrade.rb, bundle/brew.rb, cmd/leaves.rb, cmd/list.rb, formula.rb, cask/tab.rb and all related test files and fixtures
• Kept the --installed-as-dependency CLI flag in brew list and brew leaves as-is since it's a user-facing option

Could you confirm if this approach looks correct, or if there's anything I may have missed or handled incorrectly? Happy to make any adjustments!

[MikeMcQuaid]

Looks great, nice work @ooye-sanket! One more tiny suggestion.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[ooye-sanket]

@MikeMcQuaid Added the commented-out odeprecated in cmd/list.rb as suggested. Ready for re-review!

[ooye-sanket]

@MikeMcQuaid Rebased onto latest upstream/main, resolved all conflicts (absorbed loaded_from_internal_api additions), and added the commented-out odeprecated in cmd/list.rb as suggested. Ready for re-review!

[MikeMcQuaid]

Thanks! Looks good when CI is 🟢!

[ooye-sanket]

Hey @MikeMcQuaid the syntax CI check is failing, could you help point out what needs fixing? i tried a lot not getting the cause