Skip to content

fix(path): implement containment and path transforms - #1098

Merged
Kyle-Ye merged 2 commits into
mainfrom
bugfix/path
Sep 26, 2026
Merged

Kyle-Ye merged 2 commits into
mainfrom
bugfix/path

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Initialize path storage and retain Core Graphics paths for correct ownership.
  • Implement containment, element iteration, path composition, point mapping, and affine transforms, and apply coordinate-space conversions to stored paths.
  • Add regression coverage for fill rules, coordinate conversion, curve control points, path ownership, and disjoint regions.

@github-actions github-actions Bot added area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly. labels Sep 25, 2026
@Kyle-Ye
Kyle-Ye added this pull request to stack #1100 September 25, 2026 16:44
@tuist

tuist Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Ran test modules Commit
OpenSwiftUI ✅ 7 625b142cd

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 27.1s 625b142cd

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.58974% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.37%. Comparing base (ffb7d7d) to head (82e07dd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Shape/Path.swift 68.18% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   33.59%   33.37%   -0.22%     
==========================================
  Files         797      803       +6     
  Lines       61895    63817    +1922     
==========================================
+ Hits        20792    21301     +509     
- Misses      41103    42516    +1413     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit b727530 into main Sep 26, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/path branch September 26, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Color, shape, gradient, image, symbols, and graphics primitives. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant