fix: repair pre-commit on main (dead stargazers link, unpinned prettier)#6074
Merged
Conversation
…er version) - GitHub restricted stargazer lists (June 2026): /stargazers now 404s for non-collaborators, failing lychee. Point the README stars badge at the repo root instead. - The unpinned `prettier` in additional_dependencies overrode the mirror's pinned version with npm latest, so envs built after the prettier 3.9.5 release rewrite mdbook draft links `[x]()` to `[x](<>)` while 3.9.4 envs rewrite them back. Drop it so the version always matches the pinned rev. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Consumer-level additional_dependencies replace the mirror's own `prettier@<rev>` pin, so listing the (never-activated, PRQL#3078) go-template plugin left prettier unpinned since 2023 — each env rebuild installed npm latest. Drop the block so the mirror's pin applies and the version tracks the rev; accept 3.9.5's rewrite of mdbook draft links to `[x](<>)`, which mdbook renders identically. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
prql-bot
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesfails on a clean checkout of main, for two unrelated external reasons:lychee 404 on the README stars badge. GitHub restricted stargazer data in June 2026:
/stargazerspages now return 404 for everyone but a repo's own admins/collaborators. The badge link is dead for the public, so this points it at the repo root instead of excluding it from the checker.prettier was never actually pinned. The mirror pins prettier via
additional_dependencies: ["prettier@<rev>"]in its hook definition, but a consumer-leveladditional_dependenciesreplaces that list — so our unpinnedprettierentry meant every hook-env rebuild installed npm's latest. The July 6 autoupdate (chore: pre-commit autoupdate #6061) triggered a rebuild that picked up the just-released prettier 3.9.5, which rewrites empty markdown link destinations[x]()→[x](<>)(and 3.9.4 rewrites them back), making differently-built environments fight overweb/book/src/SUMMARY.md's mdbook draft-chapter links.The fix drops our
additional_dependenciesblock entirely so the mirror's own pin applies and the version tracks the rev (autoupdate then keeps them moving together), bumps to v3.9.5, and accepts its reformat of the two draft links — mdbook renders[x](<>)draft chapters identically to[x]()(verified by building the book). The droppedprettier-plugin-go-templatewas never active: its.prettierrc.yamlactivation has always been commented out (Prettier doesn't seem to work with the go-template plugin any longer #3078); anyone picking that issue up should re-add it with an explicitprettier@x.y.zpin alongside.Verified:
pre-commit run --all-filespasses twice from a clean tree, andmdbook build web/booksucceeds.