revanced-cli@6.0.0: add manifest#17910
Open
grum-sudo wants to merge 5 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe PR updates bucket/revanced-cli.json to release revanced-cli v6.0.0. The manifest sets version 6.0.0, replaces the 64-bit download URL with the revanced-cli-6.0.0-all.jar GitHub release artifact, updates the SHA-256 hash, and sets the bin entry to revanced-cli-6.0.0-all.jar. Autoupdate templates continue to use the $version placeholder. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
bucket/revanced-cli.json (1)
1-38: Testing and formatting remindersBefore merging, please ensure:
Line Endings: Scoop manifests must use CRLF line endings. Please verify your file uses CRLF (not LF).
Auto-format the manifest:
.\bin\formatjson.ps1 -App revanced-cliTest autoupdate (optional but recommended):
# Optional: Enable debug mode and set GitHub token scoop config debug true scoop config gh_token <your-token> # Read access only # Force version detection and autoupdate .\bin\checkver.ps1 -App revanced-cli -fTest installation:
scoop install .\bucket\revanced-cli.jsonFor more details, see the Contribution Guide and App Manifests Wiki.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/revanced-cli.json` around lines 1 - 38, Convert bucket/revanced-cli.json to CRLF line endings, run the formatting script .\bin\formatjson.ps1 -App revanced-cli to fix JSON formatting (including trailing commas in the "bin" arrays), then validate autoupdate by running .\bin\checkver.ps1 -App revanced-cli -f (with scoop debug/gh_token set if needed) and finally test installation with scoop install .\bucket\revanced-cli.json; ensure the "architecture", "bin" and "autoupdate" sections remain correct after these steps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/revanced-cli.json`:
- Around line 24-36: Remove the trailing comma after the second element in the
autoupdate bin tuple (the string "revanced-cli") inside the autoupdate ->
architecture -> any block; open the "autoupdate" object, locate the "bin" array
containing ["revanced-cli-$version-all.jar", "revanced-cli",] and delete the
trailing comma after "revanced-cli" so the JSON is strict-valid.
- Around line 9-14: The manifest's "architecture" entry currently lists a
"64bit" key for the Java JAR, but JARs are platform-independent and should use
the "any" architecture to match the autoupdate block; update the "architecture"
object to replace the "64bit" key with "any" (and keep the same "url" and "hash"
values) so the "architecture" symbol aligns with the autoupdate behavior and
avoids churn between runs.
- Around line 15-20: The JSON in the "bin" array contains an invalid trailing
comma after the string "revanced-cli",; remove that trailing comma so the array
element is a proper two-item array ["revanced-cli-6.0.0-all.jar",
"revanced-cli"] under the "bin" key, ensuring the file is strict JSON-valid (no
dangling commas) and passes static analysis.
---
Nitpick comments:
In `@bucket/revanced-cli.json`:
- Around line 1-38: Convert bucket/revanced-cli.json to CRLF line endings, run
the formatting script .\bin\formatjson.ps1 -App revanced-cli to fix JSON
formatting (including trailing commas in the "bin" arrays), then validate
autoupdate by running .\bin\checkver.ps1 -App revanced-cli -f (with scoop
debug/gh_token set if needed) and finally test installation with scoop install
.\bucket\revanced-cli.json; ensure the "architecture", "bin" and "autoupdate"
sections remain correct after these steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b9091d36-fb16-43bc-ae89-dfdb03f54204
📒 Files selected for processing (1)
bucket/revanced-cli.json
Comment on lines
+9
to
+14
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/ReVanced/revanced-cli/releases/download/v6.0.0/revanced-cli-6.0.0-all.jar", | ||
| "hash": "c25549bc17d59d2eb94fa5f86e60e9b77a02772ca88f7050f8f1276f923a9958" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Architecture mismatch: Java JARs are platform-independent.
The top-level manifest uses "64bit" architecture, but Java JAR files are architecture-independent and should use "any" (matching your autoupdate block at line 26). When autoupdate runs, it will regenerate the manifest with "any", creating inconsistency.
🔧 Proposed fix
"architecture": {
- "64bit": {
+ "any": {
"url": "https://github.com/ReVanced/revanced-cli/releases/download/v6.0.0/revanced-cli-6.0.0-all.jar",
"hash": "c25549bc17d59d2eb94fa5f86e60e9b77a02772ca88f7050f8f1276f923a9958"
}
},🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/revanced-cli.json` around lines 9 - 14, The manifest's "architecture"
entry currently lists a "64bit" key for the Java JAR, but JARs are
platform-independent and should use the "any" architecture to match the
autoupdate block; update the "architecture" object to replace the "64bit" key
with "any" (and keep the same "url" and "hash" values) so the "architecture"
symbol aligns with the autoupdate behavior and avoids churn between runs.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
arvdk
added a commit
to arvdk/Extras
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17907
<manifest-name[@version]|chore>: <general summary of the pull request>