-
Notifications
You must be signed in to change notification settings - Fork 1.7k
revanced-cli@6.0.0: add manifest #17910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grum-sudo
wants to merge
5
commits into
ScoopInstaller:master
Choose a base branch
from
grum-sudo:add-revanced-cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
09aa68e
moonfin@1.4.0: add manifest
grum-sudo 1cfc79d
revanced-cli@6.0.0: add manifest
grum-sudo 952a246
Merge branch 'ScoopInstaller:master' into add-revanced-cli
grum-sudo 5647760
Delete bucket/moonfin.json
grum-sudo 51f128b
Update bucket/revanced-cli.json
grum-sudo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "version": "6.0.0", | ||
| "description": "Command-line application to use ReVanced Patcher to patch Android apps.", | ||
| "homepage": "https://github.com/ReVanced/revanced-cli", | ||
| "license": "GPL-3.0-only", | ||
| "suggest": { | ||
| "java": "openjdk" | ||
| }, | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://github.com/ReVanced/revanced-cli/releases/download/v6.0.0/revanced-cli-6.0.0-all.jar", | ||
| "hash": "c25549bc17d59d2eb94fa5f86e60e9b77a02772ca88f7050f8f1276f923a9958" | ||
| } | ||
| }, | ||
| "bin": [ | ||
| [ | ||
| "revanced-cli-6.0.0-all.jar", | ||
| "revanced-cli" | ||
| ] | ||
| ], | ||
|
grum-sudo marked this conversation as resolved.
|
||
| "checkver": { | ||
| "github": "https://github.com/ReVanced/revanced-cli" | ||
| }, | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "any": { | ||
| "url": "https://github.com/ReVanced/revanced-cli/releases/download/v$version/revanced-cli-$version-all.jar" | ||
| } | ||
| }, | ||
| "bin": [ | ||
| [ | ||
| "revanced-cli-$version-all.jar", | ||
| "revanced-cli", | ||
| ] | ||
| ] | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Architecture mismatch: Java JARs are platform-independent.
The top-level manifest uses
"64bit"architecture, but Java JAR files are architecture-independent and should use"any"(matching your autoupdate block at line 26). When autoupdate runs, it will regenerate the manifest with"any", creating inconsistency.🔧 Proposed fix
"architecture": { - "64bit": { + "any": { "url": "https://github.com/ReVanced/revanced-cli/releases/download/v6.0.0/revanced-cli-6.0.0-all.jar", "hash": "c25549bc17d59d2eb94fa5f86e60e9b77a02772ca88f7050f8f1276f923a9958" } },🤖 Prompt for AI Agents