fix: intuitive template paths in custom CMS apps

[wesleyboar]

Overview / Changes

Install taccsite_custom/*/ apps before taccsite_cms to allow those custom apps to load templates from themselves before Core-CMS.

Use Cases:

• {% extend … %}
• CMS_TEMPLATES

This should fix long-standing non-intuitive template inheritance.

Warning

This may work, but then how to override a Core-CMS template? Currently, fullwidth.html extends ./base.html which extends base.html. In this branch, ./base.html extending base.html causes recursion error.

Tip

To prevent recursion error:

1. Rename Texascale's base template:
   • from …/texascale_cms/templates/base.html
   • to …/texascale_cms/templates/base_texascale.html
2. Update Texascale's fullwidth template to:
   • extend ./base_texascale.html

Untested, but makes sense.

Related

• Core Template Not Extending Project Template As Expected #168
• Implicit App Discovery is Brittle (Use CUSTOM_APPS Instead) #979
• Template Discovery Override is Unclear & Error-Prone #982
• alternative to refactor: proper django template inheritence #823

Testing

Texascale

1. Replace {% extends "./fullwidth.html" %} with {% extends "fullwidth.html" %}.
2. Verify page still loads same styles.
3. To CMS_TEMPLATES, add ('article.html', 'Article NEW').
4. Create/Open a page.
5. Switch page template between "Article" and "Article NEW".
6. Page styles and markup should not change.

APCD

1. Replace {% extends "apcd_cms/templates/standard.html" %} with {% extends "standard.html" %}.
2. Verify extension still occurs.
   ^{Page still loads React app and apcd_cms/css/site.cms.css still loads.}

UI

…

[wesleyboar]

Tip

To prevent recursion error:

1. Rename Texascale's base template:
   • from …/texascale_cms/templates/base.html
   • to …/texascale_cms/templates/base_texascale.html
2. Update Texascale's fullwidth template to:
   • extend ./base_texascale.html

Untested, but makes sense.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →