Fix: Prevent visual jitter when changing block styles#78327
Open
DarkMatter-999 wants to merge 1 commit into
Open
Fix: Prevent visual jitter when changing block styles#78327DarkMatter-999 wants to merge 1 commit into
DarkMatter-999 wants to merge 1 commit into
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #77830
This PR updates the
BlockPropshook in the block editor to useuseLayoutEffectinstead ofuseEffectwhen setting wrapper properties.Why?
When a block style variation (like "Rounded") is applied, there is currently a visual "jerk" or flash. This happens because
useEffectruns after the browser has already painted the initial state.In the case of the Image block (e.g., in Twenty Twenty-Four theme):
9999pxborder-radius/circle).useEffectfires, adding the specific theme variation classes (e.g.,is-style-rounded-[hash]).border-radius(e.g., 20px), causing a visible snap from a circle to a rounded square.How?
By switching to
useLayoutEffect, the wrapper properties (including theme-specific variation classes) are applied synchronously after all DOM mutations but before the browser has a chance to paint. This ensures the very first frame the user sees already contains the correct, theme-defined CSS classes, eliminating the intermediate "fully rounded" state.Testing Instructions
Twenty Twenty-Four).Screenshots or screencast
Before
block-style-jitter.mov
After
block-style-jitter-fix.mov
Use of AI Tools
I used Gemini 3 Flash to help draft PR description.