Skip to content

Fix: Prevent visual jitter when changing block styles #78327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkMatter-999 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+9 −2
Open

Fix: Prevent visual jitter when changing block styles #78327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/block-editor/src/hooks/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ import clsx from 'clsx';
* WordPress dependencies
*/
import { getBlockSupport } from '@wordpress/blocks';
import { memo, useMemo, useEffect, useId, useState } from '@wordpress/element';
import {
memo,
useMemo,
useEffect,
useLayoutEffect,
useId,
useState,
} from '@wordpress/element';
import { useDispatch, useRegistry } from '@wordpress/data';
import { createHigherOrderComponent } from '@wordpress/compose';
import { addFilter } from '@wordpress/hooks';
Expand Down Expand Up @@ -614,7 +621,7 @@ function BlockProps( {
} );
// Setting state after every render is fine because this component is
// pure and will only re-render when needed props change.
useEffect( () => {
useLayoutEffect( () => {
// We could shallow compare the props, but since this component only
// changes when needed attributes change, the benefit is probably small.
setWrapperProps( wrapperProps );
Expand Down
Loading