Fix hidden InnerBlocks.DefaultBlockAppender when block is deselected#78334
Open
BugReportOnWeb wants to merge 1 commit into
Open
Fix hidden InnerBlocks.DefaultBlockAppender when block is deselected#78334BugReportOnWeb wants to merge 1 commit into
InnerBlocks.DefaultBlockAppender when block is deselected#78334BugReportOnWeb wants to merge 1 commit into
Conversation
…ck is deselected
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #74060
Fixes a bug where using
renderAppender={ InnerBlocks.DefaultBlockAppender }on a block causes the appender to be hidden and a empty dashed outline to appear when the block is deselected.Why?
When a block author explicitly passes
renderAppender={ InnerBlocks.DefaultBlockAppender }toInnerBlocks, the expectation is that the “Type / to choose a block” placeholder remains visible even when the block is not selected.However,
.block-editor-default-block-appenderwas previously hidden whenever its parent block was neither selected nor has a selected child, without accounting for cases where the default appender had been explicitly forced viarenderAppender. As a result, the appender disappeared when the block was deselected.How?
block-list/index.js, detect whenCustomAppenderis explicitlyDefaultBlockAppenderand pass anisDefaultAppenderflag toBlockListAppender.block-list-appender/index.js, convert that flag into anis-default-appenderclass on the appender wrapper element, providing a reliable CSS hook.block-list/content.scss, scope the existing hiding rule so it excludes appenders explicitly rendered viarenderAppenderusing.block-list-appender:not(.is-default-appender).Testing Instructions
packages/block-library/src/group/edit.js(line 102) as following:} else if ( ! hasInnerBlocks ) { // When there is no placeholder, but the block is also empty, // use the larger button appender. - renderAppender = InnerBlocks.ButtonBlockAppender; + renderAppender = InnerBlocks.DefaultBlockAppender; }Screenshots or screencast
Use of AI Tools