Skip to content

Fix hidden InnerBlocks.DefaultBlockAppender when block is deselected #78334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BugReportOnWeb wants to merge 1 commit into
base: trunk
Choose a base branch
from
+11 −1
Open

Fix hidden InnerBlocks.DefaultBlockAppender when block is deselected #78334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/block-editor/src/components/block-list-appender/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export default function BlockListAppender( {
CustomAppender,
className,
tagName: TagName = 'div',
isDefaultAppender,
} ) {
const isDragOver = useSelect(
( select ) => {
Expand Down Expand Up @@ -78,6 +79,7 @@ export default function BlockListAppender( {
tabIndex={ -1 }
className={ clsx( 'block-list-appender wp-block', className, {
'is-drag-over': isDragOver,
'is-default-appender': isDefaultAppender,
} ) }
// Needed in case the whole editor is content editable (for multi
// selection). It fixes an edge case where ArrowDown and ArrowRight
Expand Down
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/block-list/content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ _::-webkit-full-page-media, _:future, :root [data-has-multi-selection="true"] .b
}
}

.block-editor-block-list__block:not(.is-selected):not(.has-child-selected) .block-editor-default-block-appender {
.block-editor-block-list__block:not(.is-selected):not(.has-child-selected) .block-list-appender:not(.is-default-appender) .block-editor-default-block-appender {
display: none;

.block-editor-inserter__toggle {
Expand All @@ -371,6 +371,10 @@ _::-webkit-full-page-media, _:future, :root [data-has-multi-selection="true"] .b
}
}

.block-editor-block-list__block .block-list-appender.is-default-appender .block-editor-default-block-appender {
height: fit-content;
}

.block-editor-block-list__block .block-editor-block-list__block-html-textarea {
display: block;
margin: 0;
Expand Down
4 changes: 4 additions & 0 deletions packages/block-editor/src/components/block-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { getDefaultBlockName } from '@wordpress/blocks';
*/
import BlockListBlock from './block';
import BlockListAppender from '../block-list-appender';
import DefaultBlockAppender from '../inner-blocks/default-block-appender';
import { useInBetweenInserter } from './use-in-between-inserter';
import { store as blockEditorStore } from '../../store';
import { LayoutProvider, defaultLayout } from './layout';
Expand Down Expand Up @@ -297,6 +298,9 @@ function Items( {
tagName={ __experimentalAppenderTagName }
rootClientId={ rootClientId }
CustomAppender={ CustomAppender }
isDefaultAppender={
CustomAppender === DefaultBlockAppender
}
/>
) }
</LayoutProvider>
Expand Down
Loading