Content Type: Handle duplicate slug generation for CPT's and Taxonomies #78341
Open
im3dabasia wants to merge 2 commits into
Open
Content Type: Handle duplicate slug generation for CPT's and Taxonomies #78341im3dabasia wants to merge 2 commits into
im3dabasia wants to merge 2 commits into
Conversation
…r checking all existing CPTs in the DB
… after checking all existing taxonomies in the DB
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #77600
Ensures the generated slug when duplicating a post type or taxonomy is not already taken.
Why?
buildCopySlugincremented the trailing number once without checking availability, so duplicating the same item twice pre-filled the same slug both times.How?
buildCopySlugnow loops, incrementing the trailing number, until finding a free candidate. Each modal builds atakenSlugsset from both active registered types and draft records (since duplicates are stored as drafts).Testing Instructions
test2.test3, nottest2.Testing Instructions for Keyboard
Tab to a row's actions menu → Duplicate → confirm slug field is pre-filled with a free slug → submit with Enter.