Skip to content

Content Type: Handle duplicate slug generation for CPT's and Taxonomies #78341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
im3dabasia wants to merge 2 commits into
base: trunk
Choose a base branch
from
+54 −16
Open

Content Type: Handle duplicate slug generation for CPT's and Taxonomies #78341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd79684
Content Types: Generate slugs for the duplicate CPT's optimallly afte…
im3dabasia May 15, 2026
5d61cbb
Content Types: Generate slugs for the duplicate Taxonomies optimallly…
im3dabasia May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions packages/content-types/src/post-types/actions/duplicate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
import { Button } from '@wordpress/components';
import { store as coreStore } from '@wordpress/core-data';
import { useDispatch } from '@wordpress/data';
import { useDispatch, useSelect } from '@wordpress/data';
import {
DataForm,
useFormValidity,
Expand Down Expand Up @@ -34,14 +34,20 @@ const duplicateForm: Form = {
fields: [ 'plural_name', 'singular_name', 'slug' ],
};

function buildCopySlug( slug: string ): string {
function buildCopySlug( slug: string, takenSlugs: Set< string > ): string {
const match = slug.match( /^(.*?)(\d+)$/ );
const base = match ? match[ 1 ] : slug;
const nextNumber = String( match ? parseInt( match[ 2 ], 10 ) + 1 : 2 );
return `${ base.slice(
0,
SLUG_MAX_LENGTH - nextNumber.length
) }${ nextNumber }`;
let num = match ? parseInt( match[ 2 ], 10 ) + 1 : 2;
let candidate: string;
do {
const nextNumber = String( num );
candidate = `${ base.slice(
0,
SLUG_MAX_LENGTH - nextNumber.length
) }${ nextNumber }`;
num++;
} while ( takenSlugs.has( candidate ) );
return candidate;
}

function DuplicatePostTypeModal( {
Expand All @@ -54,6 +60,19 @@ function DuplicatePostTypeModal( {
onActionPerformed?: ( items: PostTypeFormData[] ) => void;
} ) {
const source = items[ 0 ];
const takenSlugs = useSelect( ( select ) => {
const postTypes = select( coreStore ).getPostTypes() ?? [];
const drafts =
select( coreStore ).getEntityRecords(
'postType',
POST_TYPE_ENTITY,
{ status: 'draft', per_page: -1, _fields: 'id,slug' }
) ?? [];
return new Set< string >( [
...postTypes.map( ( pt: any ) => pt.slug ),
...drafts.map( ( d: any ) => d.slug ),
] );
}, [] );
const [ data, setData ] = useState< PostTypeFormData >( () => ( {
...source,
id: undefined,
Expand All @@ -65,7 +84,7 @@ function DuplicatePostTypeModal( {
source.title.raw
),
},
slug: buildCopySlug( source.slug ),
slug: buildCopySlug( source.slug, takenSlugs ),
} ) );
const [ isDuplicating, setIsDuplicating ] = useState( false );
const slugField = useSlugField( undefined, data.slug );
Expand Down
35 changes: 27 additions & 8 deletions packages/content-types/src/taxonomies/actions/duplicate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/
import { Button } from '@wordpress/components';
import { store as coreStore } from '@wordpress/core-data';
import { useDispatch } from '@wordpress/data';
import { useDispatch, useSelect } from '@wordpress/data';
import {
DataForm,
useFormValidity,
Expand Down Expand Up @@ -34,14 +34,20 @@ const duplicateForm: Form = {
fields: [ 'plural_name', 'singular_name', 'slug' ],
};

function buildCopySlug( slug: string ): string {
function buildCopySlug( slug: string, takenSlugs: Set< string > ): string {
const match = slug.match( /^(.*?)(\d+)$/ );
const base = match ? match[ 1 ] : slug;
const nextNumber = String( match ? parseInt( match[ 2 ], 10 ) + 1 : 2 );
return `${ base.slice(
0,
SLUG_MAX_LENGTH - nextNumber.length
) }${ nextNumber }`;
let num = match ? parseInt( match[ 2 ], 10 ) + 1 : 2;
let candidate: string;
do {
const nextNumber = String( num );
candidate = `${ base.slice(
0,
SLUG_MAX_LENGTH - nextNumber.length
) }${ nextNumber }`;
num++;
} while ( takenSlugs.has( candidate ) );
return candidate;
}

function DuplicateTaxonomyModal( {
Expand All @@ -54,6 +60,19 @@ function DuplicateTaxonomyModal( {
onActionPerformed?: ( items: TaxonomyFormData[] ) => void;
} ) {
const source = items[ 0 ];
const takenSlugs = useSelect( ( select ) => {
const taxonomies = select( coreStore ).getTaxonomies() ?? [];
const drafts =
select( coreStore ).getEntityRecords( 'postType', TAXONOMY_ENTITY, {
status: 'draft',
per_page: -1,
_fields: 'id,slug',
} ) ?? [];
return new Set< string >( [
...taxonomies.map( ( t: any ) => t.slug ),
...drafts.map( ( d: any ) => d.slug ),
] );
}, [] );
const [ data, setData ] = useState< TaxonomyFormData >( () => ( {
...source,
id: undefined,
Expand All @@ -65,7 +84,7 @@ function DuplicateTaxonomyModal( {
source.title.raw
),
},
slug: buildCopySlug( source.slug ),
slug: buildCopySlug( source.slug, takenSlugs ),
} ) );
const [ isDuplicating, setIsDuplicating ] = useState( false );
const slugField = useSlugField( undefined, data.slug );
Expand Down
Loading