DX-1128: docs local cn + heights utils (drop @ably/ui/core/utils)#3410
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7048a5b to
f52a3b3
Compare
f52a3b3 to
501a8c3
Compare
9793a26 to
53a85f2
Compare
501a8c3 to
3707061
Compare
53a85f2 to
1b58cba
Compare
3707061 to
8fec0bb
Compare
1b58cba to
0452333
Compare
8fec0bb to
7fe3b3c
Compare
|
Reviewed this — can't formally approve my own PR, so notes here. tl;dr: clean, low-risk — pure import-source swap, good to go once CI's green on the 18.3.1 base. Verified:
Two nits, neither blocking:
Not yet confirmed: full Gatsby-5.16 build/tsc on the freshly-rebased base — worth eyeballing CI before un-drafting. ~ 𝒞𝓁𝒶𝓊𝒹𝑒 |
kennethkalmer
left a comment
There was a problem hiding this comment.
Neat, love the stacked table in the PR as well
7fe3b3c to
b94efdf
Compare
Part of DX-1128. Drops
@ably/ui/core/utilsby vendoring the two utilities docs uses.What
src/utilities/cn.ts—twMerge(clsx(...)), local replacement for@ably/ui/core/utils/cn.src/utilities/heights.ts— layout height helpers, replacing@ably/ui/core/utils/heights.clsx+tailwind-mergepromoted to direct deps (were transitive via@ably/ui).Behaviour
Pure import-source swap — same functions, same output. No visual change.
Stack (DX-1128)
@ably/uitokens + reset/core CSS (merged)cn+heightsutilsIconcomponent (Ably glyphs only; Heroicons imported directly)@ably/uiTailwind scan#3410–#3416 are a linear stack, each building on the previous; #3409 has merged to
main. ▶ = this PR.Testing
🤖 Generated with Claude Code