Skip to content

DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413

Draft
jamiehenson wants to merge 1 commit into
dx-1128/docs-components-presentationalfrom
dx-1128/docs-components-interactive
Draft

DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413
jamiehenson wants to merge 1 commit into
dx-1128/docs-components-presentationalfrom
dx-1128/docs-components-interactive

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128. Localises the interactive components.

What

src/components/ui/SegmentedControl.tsx + TabMenu.tsx, vendored and rewired to local Icon/cn (es-toolkit direct dep). SegmentedControl's leftIcon/rightIcon props now take a ReactNode (a Heroicon or Ably <Icon> glyph passed directly, sized by the control).

Behaviour

No visual change intended.

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS (merged)
#3410 Local cn + heights utils
#3411 Docs-native Icon component (Ably glyphs only; Heroicons imported directly)
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan

#3410#3416 are a linear stack, each building on the previous; #3409 has merged to main. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dae1886c-5e86-41af-b37b-e40aa22e896b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-components-interactive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from ef72e03 to 02d982a Compare June 18, 2026 13:18
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from c57d361 to eb5a063 Compare June 18, 2026 13:18
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from 02d982a to a74f1b6 Compare June 18, 2026 14:34
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from eb5a063 to 6f2cac7 Compare June 18, 2026 14:34
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from a74f1b6 to e801746 Compare June 18, 2026 14:57
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 6f2cac7 to e11ceaf Compare June 18, 2026 14:57
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 18, 2026 14:57 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from e801746 to cee3a61 Compare June 18, 2026 15:50
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from e11ceaf to f7308b7 Compare June 18, 2026 15:50
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 18, 2026 15:50 Inactive
@jamiehenson jamiehenson marked this pull request as draft June 18, 2026 16:25
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from cee3a61 to 88c9b9f Compare June 23, 2026 13:25
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from f7308b7 to b7b6074 Compare June 23, 2026 13:25
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 23, 2026 13:26 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 23, 2026 14:11 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from b7b6074 to 622c4dd Compare June 23, 2026 16:51
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from 88c9b9f to 32bc1f7 Compare June 23, 2026 16:51
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 23, 2026 16:51 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 622c4dd to 8c73370 Compare June 23, 2026 17:15
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from 32bc1f7 to 2f29be3 Compare June 23, 2026 17:15
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 23, 2026 17:15 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-presentational branch from 2f29be3 to d9f00ba Compare June 24, 2026 08:38
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 8c73370 to 486571c Compare June 24, 2026 08:38
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--xbqjvz June 24, 2026 08:38 Inactive
…bMenu) (DX-1128)

Vendor SegmentedControl and TabMenu locally, off @ably/ui/core. SegmentedControl's
leftIcon/rightIcon props now take a ReactNode (Heroicon or Ably glyph passed
directly, sized by the control) rather than an icon-name string, matching the
glyphs-only local Icon and the rest of the localised components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

2 participants