DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413
Draft
jamiehenson wants to merge 1 commit into
Draft
DX-1128: localise interactive components (SegmentedControl, TabMenu)#3413jamiehenson wants to merge 1 commit into
jamiehenson wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 17, 2026
ef72e03 to
02d982a
Compare
c57d361 to
eb5a063
Compare
02d982a to
a74f1b6
Compare
eb5a063 to
6f2cac7
Compare
a74f1b6 to
e801746
Compare
6f2cac7 to
e11ceaf
Compare
e801746 to
cee3a61
Compare
e11ceaf to
f7308b7
Compare
This was referenced Jun 18, 2026
Merged
Open
cee3a61 to
88c9b9f
Compare
f7308b7 to
b7b6074
Compare
b7b6074 to
622c4dd
Compare
88c9b9f to
32bc1f7
Compare
622c4dd to
8c73370
Compare
32bc1f7 to
2f29be3
Compare
2f29be3 to
d9f00ba
Compare
8c73370 to
486571c
Compare
…bMenu) (DX-1128) Vendor SegmentedControl and TabMenu locally, off @ably/ui/core. SegmentedControl's leftIcon/rightIcon props now take a ReactNode (Heroicon or Ably glyph passed directly, sized by the control) rather than an icon-name string, matching the glyphs-only local Icon and the rest of the localised components.
d9f00ba to
9d02706
Compare
486571c to
94e7bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DX-1128. Localises the interactive components.
What
src/components/ui/SegmentedControl.tsx+TabMenu.tsx, vendored and rewired to local Icon/cn (es-toolkitdirect dep).SegmentedControl'sleftIcon/rightIconprops now take aReactNode(a Heroicon or Ably<Icon>glyph passed directly, sized by the control).Behaviour
No visual change intended.
Stack (DX-1128)
@ably/uitokens + reset/core CSS (merged)cn+heightsutilsIconcomponent (Ably glyphs only; Heroicons imported directly)@ably/uiTailwind scan#3410–#3416 are a linear stack, each building on the previous; #3409 has merged to
main. ▶ = this PR.Testing
🤖 Generated with Claude Code