Repository navigation
Fix metaclass issues in the type stubs - #787
Merged
Merged
Conversation
Owner
|
What does the metaclass enable/fix in a stub file? |
Contributor
Author
It's mostly a correctness thing; stubs should accurately describe the runtime situation, including metaclasses. It might make a difference in type-safety in case of So TBH, it's mostly to appease stubtest. The alternative would be to manually add these to the stubtest "allowlist" (a list of ignored errors), which sounds like more work than simply adding these metaclasses 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the typing pilgrimage that started at #785, this takes care of the largest class of stubtest errors, bringing the total of 357 errors down to 34.
Before:
After:
🧙