Repository navigation
KAFKA-21262: Do not cap total run time in ShareConsumerPerformance - #23781
Draft
unknowntpo wants to merge 1 commit into
Draft
unknowntpo wants to merge 1 commit into
unknowntpo wants to merge 1 commit into
Conversation
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
--timeout is the max time between records, but consume() also used it as a total time limit and interrupted the consumers when it was reached. Wait for every consumer task instead.
unknowntpo
force-pushed
the
fix-share-benchmark-flaky
branch
from
October 21, 2026 09:19
b7b4ed3 to
ec090b8
Compare
unknowntpo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--timeoutis documented as the maximum time between returned records,but
ShareConsumerPerformancealso used it as a limit for the wholerun. A run longer than the timeout was interrupted and the tool printed
only the header line.
This is one of the two causes of the flaky share consumer benchmarks.
The other one is fixed in #23894, which should be merged first or
together: with only this change, a benchmark run that reads 0 records
still passes.