Repository navigation
KAFKA-21262: Wait for the share group and check the record count in share benchmarks - #23894
Draft
unknowntpo wants to merge 1 commit into
Draft
unknowntpo wants to merge 1 commit into
unknowntpo wants to merge 1 commit into
Conversation
…hare benchmarks The first share group in a cluster creates __share_group_state, which can take longer than the perf tool timeout, so the tool read 0 records. Read and release one record before the measured run, and fail if the run reads too few records.
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first share group in a cluster has to wait for
__share_group_stateto be created, which can take longer than the
--timeoutof the perftool. The benchmarks now read and release one record before the measured
run, and fail if the run reads fewer records than expected. Before this,
a run that read 0 records still passed.
test_producer_and_share_consumerwrites one extra warm-up record, sothe consumer can read 1,000,001 records.
The tool side of the flakiness is fixed in #23781.