fix(tests): fix flaky FileHandler test by removing setTimeout-based LaunchQueue mock#39508
Draft
mistercrunch wants to merge 1 commit intoapache:masterfrom
Draft
fix(tests): fix flaky FileHandler test by removing setTimeout-based LaunchQueue mock#39508mistercrunch wants to merge 1 commit intoapache:masterfrom
mistercrunch wants to merge 1 commit intoapache:masterfrom
Conversation
…aunchQueue mock Replace setTimeout-based consumer auto-firing in setupLaunchQueue with synchronous invocation. The setTimeout caused the consumer callback to execute outside React's act() boundary, leading to unflushed state updates and test timeouts. Track the async consumer promise in afterEach to ensure in-flight work completes before the next test starts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes flaky
FileHandler/index.test.tsxtests that intermittently timeout at 20s. The flakiness was observed on multiple tests including 'handles Parquet file correctly' and 'handles Excel (.xls) file correctly' (e.g. GHA job 71282515731 on PR #39345).Root cause:
setupLaunchQueueusedsetTimeout(fn, 0)to auto-fire the LaunchQueue consumer callback. This caused:act()boundary (in a macrotask), so state updates weren't flushed reliablysetupLaunchQueue(fileHandle)could fail non-deterministicallyFix:
setConsumerinstead of viasetTimeout— this runs within React'sact()boundary sincesetConsumeris called fromuseEffectawaitit inafterEachto ensure all async work completes before the next test startspendingTimerIdstimer trackingBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - test-only change
TESTING INSTRUCTIONS
cd superset-frontend && npm run test -- src/pages/FileHandler/index.test.tsxand verify all 10 tests pass (1 skipped)ADDITIONAL INFORMATION