Skip to content

fix(tests): fix flaky FileHandler test by removing setTimeout-based LaunchQueue mock #39508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mistercrunch wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −11
Draft

fix(tests): fix flaky FileHandler test by removing setTimeout-based LaunchQueue mock #39508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions superset-frontend/src/pages/FileHandler/index.test.tsx
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ type LaunchQueue = {
) => void;
};

const pendingTimerIds = new Set<ReturnType<typeof setTimeout>>();
let consumerPromise: Promise<void> | null = null;

const setupLaunchQueue = (fileHandle: MockFileHandle | null = null) => {
let savedConsumer:
Expand All @@ -123,13 +123,9 @@ const setupLaunchQueue = (fileHandle: MockFileHandle | null = null) => {
setConsumer: (consumer: (params: { files?: MockFileHandle[] }) => void) => {
savedConsumer = consumer;
if (fileHandle) {
const id = setTimeout(() => {
pendingTimerIds.delete(id);
consumer({
files: [fileHandle],
});
}, 0);
pendingTimerIds.add(id);
consumerPromise = Promise.resolve(
consumer({ files: [fileHandle] }),
).then(() => undefined);
}
},
};
Expand All @@ -145,9 +141,11 @@ beforeEach(() => {
delete (window as any).launchQueue;
});

afterEach(() => {
pendingTimerIds.forEach(id => clearTimeout(id));
pendingTimerIds.clear();
afterEach(async () => {
if (consumerPromise) {
await consumerPromise.catch(() => {});
consumerPromise = null;
}
delete (window as any).launchQueue;
});

Expand Down
Loading