refactor(pxe): migrate SenderTaggingStore to BaseStagingStore - #108
Open
nchamo wants to merge 1 commit into
Open
refactor(pxe): migrate SenderTaggingStore to BaseStagingStore#108nchamo wants to merge 1 commit into
nchamo wants to merge 1 commit into
Conversation
nchamo
added
ci-draft
nchamo
changed the base branch from
nchamo/fact-store-base-staging
to
nchamo/capsule-store-base-staging
August 28, 2026 16:26
nchamo
marked this pull request as ready for review
August 28, 2026 16:49
nchamo
force-pushed
the
nchamo/sender-tagging-base-staging
branch
from
August 28, 2026 19:23
3446ee0 to
aab43dd
Compare
nchamo
force-pushed
the
nchamo/sender-tagging-base-staging
branch
from
August 28, 2026 20:04
aab43dd to
65c1fe0
Compare
nventuro
force-pushed
the
nchamo/sender-tagging-base-staging
branch
from
August 28, 2026 21:17
65c1fe0 to
3b16762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SenderTaggingStoreontoBaseStagingStore(introduced in fix(pxe): per-change-set staging store that rejects dead change sets #47), following the RecipientTaggingStore (refactor(pxe): migrate RecipientTaggingStore to BaseStagingStore #94), FactStore (refactor(pxe): migrate FactStore to BaseStagingStore #98) and CapsuleStore (refactor(pxe): migrate CapsuleStore to BaseStagingStore #101) migrations. The store's per-change-set maps,commitChangeSet/discardChangeSet, and the "one change set open at a time" bookkeeping now come from the base class; the store only implementsflushChangeSetand a no-opapplyRollback.Stacked on #101 (which stacks on #98).