Repository navigation
Conversation
Bring MetalFX ray reconstruction in line with Solari's current guide buffers and primary-surface replacement.
MetalFX reads the R32Float guide, including virtual mirror depth, so the camera depth attachment no longer takes MetalFX usages. The world-cache dispatch buffer is 16 bytes so Metal can bind the vec3<u32>.
mate-h
requested review from
JMS55,
kfc35 and
stuartparmenter
and removed request for
JMS55 and
stuartparmenter
October 25, 2026 02:10
stuartparmenter
added
C-Feature
Contributor
|
You added a new feature but didn't update the readme. Please run |
Contributor
Author
|
CC @haydenflinner and @archonic feel free to leave feedback on this PR as well! |
mate-h
added
O-Metal
Looks great! I had my agent review it too and it only called out 'specular_motion_vectors' being calculated but unused, but that doesn't seem worth the effort to fix just yet! |
alice-i-cecile
added
the
M-Release-Note
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In my last PR #25123 I got bevy_solari running on Metal, but I still didn't have a denoiser. Now a couple of people have implemented it and I have consolidated them to this branch.
On Apple, the DLSS equivalent for denoising is MetalFX.
Solution
Mostly a copy of how the dlss integration works:
The integration lives in
bevy_anti_aliasand depends on mate-h/metalfx_wgpu.The scale check and input crop follow what showed up in archonic/metalfx_denoiser. The dispatch-buffer size is from haydenflinner/bevy-solari-metalfx-only.
Testing
Ran the Solari example on my device (Mac M5).
This PR was partly produced with the assistance of AI Coding tools: Cursor IDE (Grok 4.7)