Ethereum Stop Sequence#4161
Open
MicahMaphet wants to merge 1 commit into
Open
Conversation
kajoseph
reviewed
May 12, 2026
| this.multiThreadSync.stop(); | ||
| logger.debug(`Stopping worker for chain ${this.chain} ${this.network}`); | ||
| await this.disconnect(); | ||
| setTimeout(BaseEVMStateProvider.teardownRpcs, 100); |
Contributor
Author
There was a problem hiding this comment.
It would crash the other services if done immediately.
Collaborator
There was a problem hiding this comment.
Then it seems this is in the wrong place. We should call teardownRpcs after the other services are stopped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛑 Description
Previously when using ethereum on
bitcore-node, the server would never stop. This was caused by the ethereum rpcs not stopping. This solves this by tearing down the rps with a delay of 100 ms, which prevents errors.Currently, with ethereum it still has an exit code of 1. This is unsolved.
🪵 Changelog
🧪 Testing Notes
Tested with a
bitcore.config.jsonthat only uses ethereum.Run, and stop on
masterandeth-stop:Checklist