Skip to content

Ethereum Stop Sequence #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MicahMaphet wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

Ethereum Stop Sequence #4161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bitcore-node/src/providers/chain-state/evm/p2p/p2p.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ export class EVMP2pWorker extends BaseP2PWorker<IEVMBlock> {
this.multiThreadSync.stop();
logger.debug(`Stopping worker for chain ${this.chain} ${this.network}`);
await this.disconnect();
setTimeout(BaseEVMStateProvider.teardownRpcs, 100);
Copy link
Copy Markdown
Collaborator

@kajoseph kajoseph May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the setTimeout?

Copy link
Copy Markdown
Contributor Author

@MicahMaphet MicahMaphet May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would crash the other services if done immediately.

Copy link
Copy Markdown
Collaborator

@kajoseph kajoseph May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it seems this is in the wrong place. We should call teardownRpcs after the other services are stopped.

}

async start() {
Expand Down