Skip to content

Allow a margin for eye 2d such that closely matching window sizes can be rendered - #1392

Draft
Happypig375 wants to merge 13 commits into
vulkanfrom
eye-2d-margin
Draft

Allow a margin for eye 2d such that closely matching window sizes can be rendered#1392
Happypig375 wants to merge 13 commits into
vulkanfrom
eye-2d-margin

Conversation

@Happypig375

@Happypig375 Happypig375 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Toy Box and Racecourse work on Sand Box 2d. However, Fluid Sim is full of rendering errors. I don't think they are caused by my changes.

Also, I haven't tested changing display virtual resolution at runtime yet.

@bryanedds

Copy link
Copy Markdown
Owner

Yes, please ignore the current 2D rendering errors - it's a vulkan task item that's immediately prioritized.

@bryanedds

Copy link
Copy Markdown
Owner

Heads up:

Haven't had time to dig into this PR yet, but I've solved most of the rendering glitches in Fluid Sim, but not all.

Thanks for your patience as I work through my tasks, including reviewing this!

@bryanedds

Copy link
Copy Markdown
Owner

3D still renders exclusively inside the display virtual resolution, correct?

@bryanedds

Copy link
Copy Markdown
Owner

Seems to have multiple issues still. For example -

image

@Happypig375

Copy link
Copy Markdown
Collaborator Author
  • 3D rendering will also extend the rendered viewport up to eye 2d viewed.
  • The text positioning bug has been fixed.

@bryanedds

Copy link
Copy Markdown
Owner

I'm wondering if there's any actual utility in having a finite margin size or if the margin - when enabled, I guess - should just be whatever is over the current integer display scalar before reaching the next one.

@bryanedds

Copy link
Copy Markdown
Owner

Requesting that as much testing and QA work can be done on the submitter side for this rather precarious feature. There should be time to do so since we won't be able to merge this at least until after Vulkan Preview release.

@Happypig375

Happypig375 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

The clipping and positioning of 2D entities on macOS broke after the changes of latest Vulkan, needs more experimentation

@Happypig375
Happypig375 marked this pull request as draft July 24, 2026 15:15
@Happypig375

Copy link
Copy Markdown
Collaborator Author

It's now fixed, but somehow resizing the window may trigger unwanted button clicks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants