Conversation
Add the `s3` interface (via an `s3-credentials` relation) to kfp-api, kfp-ui and kfp-profile-controller so they can use an s3-integrator as an alternative to the in-cluster MinIO (`object-storage`) backend. Exactly one of `object-storage` or `s3-credentials` may be related at a time; relating both blocks the charm. The s3 endpoint is parsed into the host, port and TLS flag the workloads expect, and the profile-controller sync hook now derives SSL/region and omits the namespace suffix for s3. Integration tests are split into object-storage and s3 suites, wired up through a new `integration-s3` tox env and CI matrix entry.
ckfbot
added
backport track/2.16
Contributor
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
Contributor
Author
|
Splitting this into three per-charm PRs for easier review: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3interface support (via ans3-credentialsrelation) to kfp-api, kfp-ui and kfp-profile-controller, letting them use an s3-integrator as an alternative to the in-cluster MinIO (object-storage) backend.object-storageors3-credentialsmay be related at a time; relating both blocks the charm (enforced by aRelationCountGateComponentconflict gate in kfp-ui/kfp-profile-controller, and inline in kfp-api).sync.pyhook now derives SSL/region and omits the.namespacesuffix when using s3.Changes
_get_object_storage_data()+_parse_s3_endpoint()supporting both backends. kfp-api usesobject_storage.S3Requirer; kfp-ui/kfp-profile-controller use chismeS3RequirerComponent+RelationCountGateComponent.sync.py(minio_ssl/minio_region, empty-namespace endpoint) andpebble_components.py(MINIO_SSL/MINIO_REGIONenv, dropped namespace-required check).s3-credentialsrelation (interfaces3).^0.4.27+object-storage-charmlib ^1.0.0(pyproject + poetry.lock).test_charm.py→test_charm_object_storage.py(pure rename) + newtest_charm_s3.py(×3); new unit tests for endpoint parsing, conflict detection, waiting status, and s3-backed pebble services.integration-s3tox env (root + per-charm), S3 passenv, andintegration-s3CI matrix entry with excludes for charms that don't integrate with s3.Behavior change
OBJECTSTORECONFIG_SECUREnow derives from theobject-storagerelation'ssecurefield instead of being hardcoded tofalse.Closes #902