feat(kfp-profile-controller): add s3-credentials relation to relate with s3-integrator by mvlassis · Pull Request #958 · canonical/kfp-operators

mvlassis · 2026-06-18T12:48:12Z

Summary

Add s3 interface support (via an s3-credentials relation) to kfp-profile-controller, letting it use an s3-integrator as an alternative to the in-cluster MinIO (object-storage) backend.
A RelationCountGateComponent conflict gate enforces that exactly one of object-storage or s3-credentials is related at a time (relating both, or neither, blocks the charm).
Add three new MINIO_* arguments passed into the sync.py workload container

Notes

Split out of feat: support s3-integrator as an object storage backend #955.
The root tox.ini change is identical across the three split PRs (conflict-free); the ci.yaml matrix enables integration-s3 only for kfp-profile-controller here, so merging the companion PRs will require a small exclude-list merge.

Closes #966

Add the `s3` interface (via an `s3-credentials` relation) so kfp-profile-controller can use an s3-integrator as an alternative to the in-cluster MinIO (`object-storage`) backend. A RelationCountGateComponent enforces that exactly one of the two relations is related at a time. The s3 endpoint is parsed into the MINIO_* host, port and SSL flag, and the sync hook now derives SSL/region and omits the `.namespace` suffix when using s3 (which has no namespace concept). Integration tests are split into object-storage and s3 suites, wired up through a new `integration-s3` tox env and CI matrix entry.

ckfbot · 2026-06-18T12:48:42Z

🤖 Backport labels populated

Labels to this pull request were added automatically by the populate-labels.yaml action.

When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR.

…tegration-object-storage env

…ontroller # Conflicts: # .github/workflows/ci.yaml # tox.ini

NohaIhab

Thank you @mvlassis, I left some comments/questions

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py:487

Application.remove_relation() expects fully-qualified relation endpoints (e.g., app:endpoint). Passing just "object-storage" is inconsistent with the earlier call in this file and is likely to error at runtime. Use the explicit app endpoint for the charm side.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

NohaIhab

Thank you @mvlassis, just a Q on the secure field

NohaIhab

Thanks @mvlassis

mvlassis mentioned this pull request Jun 18, 2026

feat: support s3-integrator as an object storage backend #955

Closed

ckfbot added backport track/2.16 Backport to track/2.16 backport track/2.15 Backport to track/2.15 backport track/2.5 Backport to track/2.5 labels Jun 18, 2026

mvlassis temporarily deployed to edge-pr June 18, 2026 12:56 — with GitHub Actions Inactive

ci(kfp-profile-controller): run s3 in default integration env, add in…

a3942c2

…tegration-object-storage env

mvlassis had a problem deploying to edge-pr June 18, 2026 13:38 — with GitHub Actions Error

mvlassis temporarily deployed to edge-pr June 18, 2026 13:38 — with GitHub Actions Inactive

mvlassis had a problem deploying to edge-pr June 18, 2026 13:38 — with GitHub Actions Error

mvlassis temporarily deployed to edge-pr June 18, 2026 13:38 — with GitHub Actions Inactive

mvlassis had a problem deploying to edge-pr June 18, 2026 13:38 — with GitHub Actions Error

mvlassis had a problem deploying to edge-pr June 18, 2026 13:38 — with GitHub Actions Failure

mvlassis had a problem deploying to edge-pr June 18, 2026 13:38 — with GitHub Actions Error

Update tox docs

4da41a9

mvlassis temporarily deployed to edge-pr June 18, 2026 14:12 — with GitHub Actions Inactive

mvlassis added 5 commits June 25, 2026 11:54

Add validation for the relation data

d844527

Update tests

45de7a7

Merge remote-tracking branch 'origin/main' into kf-8704-kfp-profile-c…

745001f

…ontroller # Conflicts: # .github/workflows/ci.yaml # tox.ini

Add test for status when both object-storage relations are present

033d557

Add test to test charm status

cdaea44

NohaIhab requested changes Jun 26, 2026

View reviewed changes

Comment thread .github/workflows/ci.yaml Outdated

Comment thread charms/kfp-profile-controller/src/charm.py Outdated

Comment thread charms/kfp-profile-controller/tests/integration/test_charm_s3.py

Comment thread charms/kfp-profile-controller/src/charm.py Outdated

MattiaSarti approved these changes Jun 26, 2026

View reviewed changes

mvlassis added 2 commits June 29, 2026 10:59

Address comments

bcaa621

Test actual charm status in unit tests

4f23c2a

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread charms/kfp-profile-controller/tests/unit/test_operator.py

Comment thread charms/kfp-profile-controller/tests/unit/test_operator.py

MattiaSarti approved these changes Jun 30, 2026

View reviewed changes

mvlassis and others added 6 commits June 30, 2026 09:45

Fix unit tests

3f949a6

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Fix unit tests

3aad7ca

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Test actual charm status in unit tests

f8298bc

Increase timeout for validate_profile_deployments_with_custom_images

65de018

Address comments

db819c5

Update docstrings

c323020

Copilot AI reviewed Jun 30, 2026

View reviewed changes

mvlassis and others added 5 commits June 30, 2026 14:46

Potential fix for pull request finding

3e699a2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Potential fix for pull request finding

47a996b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Potential fix for pull request finding

e50419a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Potential fix for pull request finding

17f0ee6

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Manos Vlassis <57320708+mvlassis@users.noreply.github.com>

Update port to string

c7bfa06

NohaIhab reviewed Jul 1, 2026

View reviewed changes

Comment thread charms/kfp-profile-controller/src/components/object_storage_validator.py Outdated

Comment thread charms/kfp-profile-controller/src/components/object_storage_validator.py Outdated

Comment thread charms/kfp-profile-controller/src/components/object_storage_validator.py

mvlassis added 4 commits July 1, 2026 12:28

Address comments

31cca5f

Address comments

2a99824

Fix linting

4bf8b07

Address comments

7b744c8

NohaIhab approved these changes Jul 1, 2026

View reviewed changes

mvlassis mentioned this pull request Jul 2, 2026

feat(kfp-ui): add s3-credentials relation to relate with s3-integrator #957

Open

Uh oh!

Conversation

mvlassis commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Uh oh!

ckfbot commented Jun 18, 2026

🤖 Backport labels populated

Uh oh!

NohaIhab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NohaIhab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NohaIhab left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mvlassis commented Jun 18, 2026 •

edited

Loading