Skip to content

Fix clippy recipe to fail on warnings#109

Open
nanookclaw wants to merge 1 commit into
channable:masterfrom
nanookclaw:fix/clippy-warnings-fail
Open

Fix clippy recipe to fail on warnings#109
nanookclaw wants to merge 1 commit into
channable:masterfrom
nanookclaw:fix/clippy-warnings-fail

Conversation

@nanookclaw
Copy link
Copy Markdown

Closes #106.

This keeps the existing cargo clippy --fix pass, then runs clippy again without --fix. That second pass preserves the -Dwarnings exit behavior, so lint-heavy fails when warnings remain instead of accepting them after cargo fix.

Running the stricter pass exposed existing Python binding error-shape lints. I marked the few rich error-returning methods with the same local allow style already used for type complexity, adding result_large_err where needed. Cargo also refreshed the two local package versions in Cargo.lock from 0.35.1 to 0.35.2 to match Cargo.toml.

Verification:

  • just --show clippy
  • just --dry-run clippy
  • cargo fmt --check
  • cargo clippy --no-deps -- -Dwarnings
  • just clippy

I also ran just lint-heavy; clippy passed, then mypy stopped on missing local Python dependencies/stubs (cbor2, multiprocess, opentelemetry exporter) before code-specific type errors.

Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cargo Clippy succeeds with warnings if --fix is passed

1 participant