Skip to content

Fix clippy recipe to fail on warnings #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanookclaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix clippy recipe to fail on warnings #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ lint-heavy: clippy mypy
[group('lint')]
clippy:
cargo clippy --no-deps --fix --allow-dirty --allow-staged -- -Dwarnings
cargo clippy --no-deps -- -Dwarnings

# Python static analysis type-checker
[group('lint')]
Expand Down
7 changes: 4 additions & 3 deletions libs/opsqueue_python/src/producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ impl ProducerClient {
///
/// Will return an error if the submission is already complete, failed, or
/// cancelled, or if the submission could not be found.
#[allow(clippy::result_large_err, clippy::type_complexity)]
pub fn cancel_submission(
&self,
py: Python<'_>,
Expand Down Expand Up @@ -284,7 +285,7 @@ impl ProducerClient {
})
}

#[allow(clippy::type_complexity)]
#[allow(clippy::result_large_err, clippy::type_complexity)]
pub fn try_stream_completed_submission_chunks(
&self,
py: Python<'_>,
Expand Down Expand Up @@ -313,7 +314,7 @@ impl ProducerClient {
}

#[pyo3(signature = (chunk_contents, metadata=None, strategic_metadata=None, chunk_size=None, otel_trace_carrier=CarrierMap::default()))]
#[allow(clippy::type_complexity)]
#[allow(clippy::result_large_err, clippy::type_complexity)]
pub fn run_submission_chunks(
&self,
py: Python<'_>,
Expand Down Expand Up @@ -364,7 +365,7 @@ impl ProducerClient {
/// to reduce the latency of tiny submissions.
/// This interval is then doubled for each subsequent poll,
/// until we check every few seconds.
#[allow(clippy::type_complexity)]
#[allow(clippy::result_large_err, clippy::type_complexity)]
pub fn blocking_stream_completed_submission_chunks(
&self,
py: Python<'_>,
Expand Down