Support OpaqueTypes in Lookupable#5400
Merged
Merged
Conversation
AI-assisted-by: Claude Code (Claude Sonnet 4.6)
AI-assisted-by: Claude Code (Claude Sonnet 4.6)
AI-assisted-by: Claude Code (Claude Sonnet 4.6)
uenoku
reviewed
May 30, 2026
| case (LitIndex(_, n), vec: Vec[_]) => vec.apply(n) | ||
| case (Index(_, ILit(n)), vec: Vec[_]) => vec.apply(n.toInt) | ||
| case (ModuleIO(_, name), rec: Record) => rec._elements(name) | ||
| case (OpaqueSlot(_), rec: Record) => rec._elements("") |
Contributor
There was a problem hiding this comment.
Is it okay to drop OpaqueSlot's name here?
Contributor
Author
There was a problem hiding this comment.
I appreciate the close eye--OpaqueSlot's don't actually have a name (required to be ""), that's a reference to the parent Data so okay in this case!
uenoku
approved these changes
May 30, 2026
Contributor
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When cloning to context a
Datathat is a child of someAggregate, Lookupable has to clone the rootDataand then return the equivalent child (potentially deeply nested) which involves walking up and then back down the Aggregate hierarchy. Previously this did not properly supportOpaqueTypesnow it does.Release Notes
Fix bug in
LookupableforOpaqueTypesDevelopment notes