fix(routing): normalize path.relative() results for Windows compat#2547
Open
hiro-nikaitou wants to merge 3 commits into
Open
fix(routing): normalize path.relative() results for Windows compat#2547hiro-nikaitou wants to merge 3 commits into
hiro-nikaitou wants to merge 3 commits into
Conversation
# Resolved conflict: computeLayoutTreePositions - keep upstream's # robust empty-string check (handles mixed separators on win32) # while applying normalizePathSeparators and '/' split from PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows Node.js
path.relative()andpath.join()return backslash paths. Vite normalizes all paths to forward slashes. Without normalization, Windows users hit cache misses and failed route lookups.Prior PRs #1578 (StaticFileCache) and #1604 (normalizePathSeparators utility) addressed the first cases. This extends normalization to all remaining sites in the route graph builder.
Changes
All in
packages/vinext/src/routing/app-route-graph.ts:findSlotSubPages: wrappath.relative()withnormalizePathSeparators()findSlotConfigLayoutTreePositions: normalize + "/" splitcomputeLayoutTreePositions: normalize + "/" splitVerification
Closes #1605.