Praetorian Acid Grenade changes - #12617
Conversation
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Drulikar
left a comment
There was a problem hiding this comment.
Needs to not go over blocking cades
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
PASS_ACID_GRENADE is inside PASS_OVER, no need to add it to initialize unless adding it to PASS_OVER was bad idea.
| flags_can_pass_front_temp |= PASS_OVER_THROW_MOB|PASS_ACID_GRENADE | ||
| flags_can_pass_behind_temp |= PASS_OVER_THROW_MOB|PASS_ACID_GRENADE |
There was a problem hiding this comment.
Still funky IMO that temps will have only PASS_OVER_THROW_MOB
cmss13/code/game/objects/structures/barricade/barricade.dm
Lines 80 to 87 in c890d89
But after unwiring the temps will have PASS_OVER_THROW_MOB|PASS_ACID_GRENADE but it ultimately doesn't change behavior because yes you have it in PASS_OVER
Feedback:
https://discord.com/channels/150315577943130112/1464087612796174501
Detached from: #12601
About the pull request
Increases acid grenade speed by one tier and changes launch_type to "HIGH_LAUNCH"
Explain why it's good for the game
Prae acid grenades are at wierd spot, they are partially dependant on RNG mechanic, but this PR is not about RNG issue, it is more about "time dilation" that you can experience in game, when throwing grenade it sometimes can travel slower than observed on private instance (most of time when server start to lag or slow down by some code issues), and in general this skill is not as fast as it should be.
With this change acid grenades travel slightly faster and can travel over obstacles such as handrails, racks or closets, of course in exchange for speed increase and better throwing of acid grenades your fuze time of acid grenade is increased from 1s to 1.25s
Testing Videos
2026-07-10.12-04-53.mp4
2026-07-10.11-57-00.mp4
Changelog
🆑 Venuska1117
balance: Praetorian acid grenade got increased throwing speed and launch_type changed to "HIGH_LAUNCH", allowing it to throw over more obstacles such as railings or closets, but in exchange "explosion" time is increased from 1s to 1.25s
fix: Fixed cades that got unwired not getting back their pass_flags.
/:cl: