Skip to content

[REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and early DEAD target check. - #12632

Open
Venuska1117 wants to merge 3 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-vampire
Open

[REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and early DEAD target check.#12632
Venuska1117 wants to merge 3 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-vampire

Conversation

@Venuska1117

@Venuska1117 Venuska1117 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Detached from: #12601

About the pull request

Updates abilities code, fixes vampire headbite lacking checks for cooldown and if target is DEAD.

Explain why it's good for the game

Cleaner code, easier to follow, fixing issues.

Testing Procedure

Made new code, run code, no errors.
spawn vampire, use abilities, abilities work fine.
use headbite, headbite cannot attack on cooldown.
use headbite on dead target, ability stops instantly instead of after delay.

Code works as intended.

Changelog

🆑 Venuska1117
refactor: Updates Vampire code for cleaner look and making it easier to follow.
fix: Added missing cooldown check on vampire headbite and early return check if target is DEAD.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 12, 2026
@cmss13-ci cmss13-ci Bot added Refactor Make the code harder to read Fix Fix one bug, make ten more size/S Denotes a PR that changes 19-49 lines, ignoring generated files. labels Jul 12, 2026
@Venuska1117 Venuska1117 changed the title [REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and target DEAD check. [REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and DEAD target check. Jul 12, 2026
@cmss13-ci

cmss13-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Jul 20, 2026
@cmss13-ci cmss13-ci Bot closed this Jul 28, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Closed in Review Backlog Jul 28, 2026
@MistChristmas MistChristmas reopened this Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Closed to Awaiting Review in Review Backlog Jul 30, 2026
@Venuska1117 Venuska1117 changed the title [REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and DEAD target check. [REFACTOR] Updates Vampire strain code, fixes missing headbite cooldown and early DEAD target check. Jul 30, 2026
@cmss13-ci cmss13-ci Bot removed the Stale beg a maintainer to review your PR label Jul 31, 2026
@cmss13-ci

cmss13-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Aug 8, 2026
@Venuska1117
Venuska1117 marked this pull request as draft August 8, 2026 09:28
@Venuska1117
Venuska1117 marked this pull request as ready for review August 8, 2026 09:30
@cmss13-ci cmss13-ci Bot removed the Stale beg a maintainer to review your PR label Aug 9, 2026
Comment thread code/modules/mob/living/carbon/xenomorph/strains/castes/lurker/vampire.dm Outdated
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Changes Requested in Review Backlog Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fix one bug, make ten more Refactor Make the code harder to read size/S Denotes a PR that changes 19-49 lines, ignoring generated files.

Projects

Status: Changes Requested

Development

Successfully merging this pull request may close these issues.

2 participants