Skip to content

Changes Runner bone spur ability to use get_turf() instead of locate(). - #12634

Merged
boskoramen merged 3 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-runner
Aug 12, 2026
Merged

Changes Runner bone spur ability to use get_turf() instead of locate().#12634
boskoramen merged 3 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-runner

Conversation

@Venuska1117

@Venuska1117 Venuska1117 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Detached from: #12601

About the pull request

replaces locate() with get_turf()

Explain why it's good for the game

Update code, better logic.

Testing Procedure

Made new code, run code, no errors.
spawn runner, use bone spur, bone spur work fine.

Code works as intended.

Changelog

🆑 Venuska1117
refactor: Changes Runner bone_spur code to use get_turf() instead of locate().
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 12, 2026
@cmss13-ci cmss13-ci Bot added Refactor Make the code harder to read size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Jul 12, 2026
fira
fira previously requested changes Jul 14, 2026

@fira fira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put it in this file?

Comment thread code/modules/mob/living/carbon/xenomorph/castes/Runner.dm Outdated
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Changes Requested in Review Backlog Jul 14, 2026
@Venuska1117

Venuska1117 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

why put it in this file?

stuff from _powers.dm should be moved to other files, we already have runner.dm and runner_abilities.dm spreading to more files like runner_powers.dm is confusing.

This changes are also in this PR, this one moves most powers.dm to their respective files to decrease bloat. (could make reviewing this code easier if it was merged)
#12607

@cmss13-ci

cmss13-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Jul 22, 2026
@cmss13-ci cmss13-ci Bot closed this Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Changes Requested to Closed in Review Backlog Jul 30, 2026
@MistChristmas MistChristmas reopened this Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Closed to Awaiting Review in Review Backlog Jul 30, 2026
boskoramen
boskoramen previously approved these changes Jul 30, 2026
@boskoramen
boskoramen requested a review from fira July 30, 2026 23:39
@cmss13-ci cmss13-ci Bot removed the Stale beg a maintainer to review your PR label Jul 31, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 2, 2026
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Venuska1117 Venuska1117 changed the title [REFACTOR] Updates Runner code. [FIX] Fixes Runner code. Aug 3, 2026
@cmss13-ci cmss13-ci Bot added size/XS Denotes a PR that changes 0-19 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels Aug 3, 2026
@cmss13-ci cmss13-ci Bot added the Fix Fix one bug, make ten more label Aug 3, 2026
@Venuska1117 Venuska1117 changed the title [FIX] Fixes Runner code. Changes Runner bone spur ability to use get_turf() instead of loacte(). Aug 3, 2026
@cmss13-ci cmss13-ci Bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Aug 3, 2026
@Venuska1117 Venuska1117 changed the title Changes Runner bone spur ability to use get_turf() instead of loacte(). Changes Runner bone spur ability to use get_turf() instead of locate(). Aug 3, 2026
@cmss13-ci

cmss13-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@cmss13-ci cmss13-ci Bot added the Stale beg a maintainer to review your PR label Aug 10, 2026
@boskoramen boskoramen removed the Stale beg a maintainer to review your PR label Aug 12, 2026
@boskoramen
boskoramen dismissed fira’s stale review August 12, 2026 02:59

no longer applicable

@boskoramen
boskoramen added this pull request to the merge queue Aug 12, 2026
Merged via the queue into cmss13-devs:master with commit 428d0d4 Aug 12, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Merged in Review Backlog Aug 12, 2026
cmss13-ci Bot added a commit that referenced this pull request Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Refactor Make the code harder to read size/XS Denotes a PR that changes 0-19 lines, ignoring generated files.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants