Skip to content

Xeno ability duration is now displayed on action button. - #12684

Open
Venuska1117 wants to merge 9 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-duration
Open

Xeno ability duration is now displayed on action button.#12684
Venuska1117 wants to merge 9 commits into
cmss13-devs:masterfrom
Venuska1117:nu2-duration

Conversation

@Venuska1117

@Venuska1117 Venuska1117 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

https://discord.com/channels/150315577943130112/1464087612796174501

Core Detached from: #12601

About the pull request

Active Duration Display for abilities such as:

  • Steelcrest "Soak"
  • Lurker "Invisibility"
  • Spitter "Charge Spit"
  • Hedge "Spike Shed"
  • Acider "For The Hive"
  • Oppressor "Abduct"
  • Dancer "Dodge"

Could be easier to review this code if below was merged first:

Merging any of PR's listed below could decrease PR size, making review of this easier:

Explain why it's good for the game

Players now have visual display of time of active ability, previously it relied mostly on "gut" feeling making it very bad in some situations, best example i could give is, witnessing people missing their "For The Hive" timing, because of my previous poor implementation in #9367 of visual display, people keep missing their timing even if it was more responsive than slower status update, it still make people impatient during last 2 seconds.

With this change now you can actually SEE how much time is left on active ability instead of need to "guess", there are other abilities that have duration like ravager rage, but this one apply cooldown immediately to ability and had visual display so i didn't touch them.

Testing Videos

▶️ Display of ability duration
2026-07-19.22-00-16.mp4

Changelog

🆑 Venuska1117
qol: Xeno abilities with active duration, such as: Steelcrest "Soak", Lurker "Invisibility", Spitter "Charge Spit", Hedge "Spike Shed", Acider "For The Hive", Oppressor "Abduct" and Dancer "Dodge" , now they have their time displayed on action button similar how cooldown is displayed.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jul 19, 2026
@Venuska1117
Venuska1117 marked this pull request as draft July 19, 2026 19:45
@cmss13-ci cmss13-ci Bot added Quality of Life Make the game harder to play size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. labels Jul 19, 2026
@fira

fira commented Jul 23, 2026

Copy link
Copy Markdown
Member

Looks good at a glance, need to look again later and then we should TM this

Also please stop changing all the if () spaces and variable names when you don't touch them, it makes for huge diffs and is awful to review 😭

@fira fira added the Needs Testing Need to test it on the guinea pigs (production server) label Jul 23, 2026
@Venuska1117

Venuska1117 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Looks good at a glance, need to look again later and then we should TM this

Also please stop changing all the if () spaces and variable names when you don't touch them, it makes for huge diffs and is awful to review 😭

it was supposed to be smaller when side PR's are merged, but yeah i will try to decrease size when possible.
(also reason why it is as WIP for now so i can fix stuff up)

@cmss13-ci cmss13-ci Bot added size/XL Denotes a PR that changes 799-1999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. labels Jul 24, 2026
@Venuska1117
Venuska1117 marked this pull request as ready for review July 26, 2026 12:15
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 28, 2026
@Venuska1117
Venuska1117 marked this pull request as draft July 30, 2026 14:56
@Venuska1117
Venuska1117 marked this pull request as ready for review July 30, 2026 14:56
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 30, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 2, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2026
@cm13-github

Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Testing Need to test it on the guinea pigs (production server) Quality of Life Make the game harder to play size/XL Denotes a PR that changes 799-1999 lines, ignoring generated files.

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

3 participants