[pull] master from mozilla:master#444
Merged
Merged
Conversation
… (PR 21247 follow-up) Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error: ``` Uncaught TypeError: The specifier “web-digital_signature_properties_manager” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”. app.js:97:44 ```
…er.prototype.setDocument` (PR 21247 follow-up) This corresponds to the initial values of these fields, and they were *already* reset when a (previous) PDF document was closed.
The warn and error state badges shipped as byte-identical files (an X-in-circle glyph). Drop the redundant toolbarButton-signaturePropertiesWarn.svg and point the warn state at the error icon instead; the amber-vs-red distinction is preserved via background-color (--sig-icon-warn vs --sig-icon-error), not the glyph.
…umbnailViewer.prototype.#updateStatus`
…-warn-icon Deduplicate the signature-properties warn/error toolbar icon
l10n: Update locale files
…er-geckoview [GeckoView] Add `web-digital_signature_properties_manager` import map (PR 21247 follow-up)
…teStatus-isCopy Reduce duplication when updating undoButton/undoCloseButton in `PDFThumbnailViewer.prototype.#updateStatus`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )