Skip to content

[pull] master from mozilla:master #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 9 commits into from
Jul 3, 2026
Merged

[pull] master from mozilla:master #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a1f1a56
[GeckoView] Add `web-digital_signature_properties_manager` import map…
Snuffleupagus Jul 2, 2026
12691fd
Remove unnecessary class-field resetting in `SignaturePropertiesManag…
Snuffleupagus Jul 2, 2026
34629bd
Deduplicate the signature-properties warn/error toolbar icon
beurdouche Jul 2, 2026
f373fbf
Reduce duplication when updating undoButton/undoCloseButton in `PDFTh…
Snuffleupagus Jul 2, 2026
95604a3
l10n: Update locale files
github-actions[bot] Jul 3, 2026
4952e4d
Merge pull request #21530 from beurdouche/dedupe-signature-properties…
calixteman Jul 3, 2026
394a08f
Merge pull request #21532 from mozilla/update-locales
calixteman Jul 3, 2026
44ae5b0
Merge pull request #21529 from Snuffleupagus/SignaturePropertiesManag…
calixteman Jul 3, 2026
ab90210
Merge pull request #21531 from Snuffleupagus/PDFThumbnailViewer-#upda…
calixteman Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion l10n/kab/viewer.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ pdfjs-document-properties-creator = Yerna-t:
pdfjs-document-properties-producer = Afecku n uselket PDF:
pdfjs-document-properties-version = Lqem PDF:
pdfjs-document-properties-page-count = Amḍan n yisebtar:
pdfjs-document-properties-page-size = Tuγzi n usebter:
pdfjs-document-properties-page-size = Teɣzi n usebter:
pdfjs-document-properties-page-size-unit-inches = deg
pdfjs-document-properties-page-size-unit-millimeters = mm
pdfjs-document-properties-page-size-orientation-portrait = s teɣzi
Expand Down
4 changes: 2 additions & 2 deletions web/digital_signature_properties.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
background-color: var(--sig-icon-verified);
}
&.state-warn::before {
mask-image: var(--toolbarButton-signaturePropertiesWarn-icon);
mask-image: var(--toolbarButton-signaturePropertiesError-icon);
background-color: var(--sig-icon-warn);
}
&.state-error::before {
Expand Down Expand Up @@ -297,7 +297,7 @@
}
&.cert--untrusted::before,
&.cert--expired::before {
mask-image: var(--toolbarButton-signaturePropertiesWarn-icon);
mask-image: var(--toolbarButton-signaturePropertiesError-icon);
background-color: var(--sig-icon-warn);
}
&.cert--revoked::before,
Expand Down
4 changes: 0 additions & 4 deletions web/digital_signature_properties_manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,6 @@ class SignaturePropertiesManager {
if (!pdfDocument) {
return;
}
this.#signatures = [];
this.#results.clear();
this.#pendingVerify.clear();
this.#isLoading = true;
this.#render();

Expand All @@ -274,7 +271,6 @@ class SignaturePropertiesManager {
signatures = await pdfDocument.getSignatures();
} catch (ex) {
console.warn("getSignatures failed:", ex);
signatures = [];
}
if (pdfDocument !== this.#pdfDocument) {
return;
Expand Down
7 changes: 0 additions & 7 deletions web/images/toolbarButton-signaturePropertiesWarn.svg
View file
Open in desktop

This file was deleted.

21 changes: 8 additions & 13 deletions web/pdf_thumbnail_viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,19 +1215,14 @@ class PDFThumbnailViewer {
}
this.#toggleBar("undo", l10nId, { count });

if (type === "copy") {
this.#undoButton.firstElementChild.setAttribute(
"data-l10n-id",
"pdfjs-views-manager-status-done-button-label"
);
this.#undoCloseButton.classList.toggle("hidden", true);
} else {
this.#undoButton.firstElementChild.setAttribute(
"data-l10n-id",
"pdfjs-views-manager-status-undo-button-label"
);
this.#undoCloseButton.classList.toggle("hidden", false);
}
const isCopy = type === "copy";
this.#undoButton.firstElementChild.setAttribute(
"data-l10n-id",
isCopy
? "pdfjs-views-manager-status-done-button-label"
: "pdfjs-views-manager-status-undo-button-label"
);
this.#undoCloseButton.classList.toggle("hidden", isCopy);
}

#moveDraggedContainer(dx, dy) {
Expand Down
1 change: 1 addition & 0 deletions web/viewer-geckoview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
"web-print_service": "./pdf_print_service.js",
"web-secondary_toolbar": "./stubs-geckoview.js",
"web-signature_manager": "./stubs-geckoview.js",
"web-digital_signature_properties_manager": "./digital_signature_properties_manager.js",
"web-toolbar": "./toolbar-geckoview.js",
"web-views_manager": "./stubs-geckoview.js"
}
Expand Down
1 change: 0 additions & 1 deletion web/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
--toolbarButton-editorStamp-icon: url(images/toolbarButton-editorStamp.svg);
--toolbarButton-editorSignature-icon: url(images/toolbarButton-editorSignature.svg);
--toolbarButton-signaturePropertiesVerified-icon: url(images/toolbarButton-signaturePropertiesVerified.svg);
--toolbarButton-signaturePropertiesWarn-icon: url(images/toolbarButton-signaturePropertiesWarn.svg);
--toolbarButton-signaturePropertiesError-icon: url(images/toolbarButton-signaturePropertiesError.svg);
--signatureProperties-rowCheck-icon: url(images/signature-properties-row-check.svg);
--toolbarButton-menuArrow-icon: url(images/toolbarButton-menuArrow.svg);
Expand Down
Loading