feat: UI review implementation - #444
Draft
code-snippets-bot wants to merge 47 commits into
Draft
Conversation
sheabunge
reviewed
Aug 7, 2026
| }, | ||
| "dependencies": { | ||
| "@codemirror/fold": "^0.19.4", | ||
| "@tabler/icons-react": "^3.46.0", |
Member
There was a problem hiding this comment.
Would be good to avoid this dependency. We're just using the down chevron – could swap with this? https://developer.wordpress.org/resource/dashicons/#arrow-down-alt2
Contributor
There was a problem hiding this comment.
Agree, we should reduce dependencies. If we use specific icons, we can create icon components. We already do that in src/js/components/common/icons/.
| $handle = 'code-snippets-settings'; | ||
| $handle = 'code-snippets-settings'; | ||
| $plugin_dir = plugin_dir_path( PLUGIN_FILE ); | ||
| $css_version = filemtime( $plugin_dir . 'dist/settings.css' ); |
Member
There was a problem hiding this comment.
I think we can avoid this filemtime versioning outside of dev.
Contributor
Author
There was a problem hiding this comment.
Fixed in 904795d — removed the filemtime versioning, reverted to PLUGIN_VERSION.
|
|
||
| enqueue_code_editor( $this->snippet->type ); | ||
|
|
||
| $plugin_dir = plugin_dir_path( PLUGIN_FILE ); |
Member
There was a problem hiding this comment.
Unsure how necessary this is, but I'll leave it as-is.
| const SnippetTypeTab: React.FC<SnippetTypeTabProps> = ({ type, count }) => { | ||
| const { currentType, setCurrentType } = useSnippetsFilters() | ||
| const tabName = type ?? 'all' | ||
| const showCount = count !== undefined && (!type || 'php' === type || 'html' === type) |
Member
There was a problem hiding this comment.
Make this depend on pro status.
| </span> <TagsColumn snippet={snippet} /> | ||
| </span>)} | ||
| {0 < snippet.tags.length || snippet.modified | ||
| ? <div className={`snippet-card-meta${0 < snippet.tags.length ? ' has-tags' : ''}`}> |
|
|
||
| return options?.enabled | ||
| ? <div className="snippet-tags-container"> | ||
| <h3>{__('Snippet Tags', 'code-snippets')}</h3> |
| <details className="toolbar-more-menu"> | ||
| <summary> | ||
| {__('More', 'code-snippets')} | ||
| <IconChevronDown size={16} stroke={2} aria-hidden="true" /> |
| <div className="code-snippets-preview-modal__buttons">{children}</div> | ||
| <div className="code-snippets-preview-modal__buttons"> | ||
| {children} | ||
| <CopyCodeButton code={code} /> |
ramiy
requested changes
Aug 7, 2026
imantsk
reviewed
Aug 7, 2026
Comment on lines
+74
to
+79
| $plugin_dir = plugin_dir_path( PLUGIN_FILE ); | ||
| $css_version = filemtime( $plugin_dir . 'dist/manage.css' ); | ||
| $js_version = filemtime( $plugin_dir . 'dist/manage.js' ); | ||
| $css_version = false !== $css_version ? $css_version : PLUGIN_VERSION; | ||
| $js_version = false !== $js_version ? $js_version : PLUGIN_VERSION; | ||
|
|
imantsk
reviewed
Aug 7, 2026
| * @return bool | ||
| */ | ||
| public function is_upsell_view(): bool { | ||
| return in_array( $this->get_current_subpage(), [ 'blueprints', 'cloud-library' ], true ); |
Member
There was a problem hiding this comment.
should avoid hardcoding view names
…, avoid hardcoded subpage names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of the Code Snippets UI review findings by John Fraskos. This PR covers all approved visual, accessibility, and behavioral changes across the Manage, Editor, Settings, and Blueprints surfaces.
Canonical design spec: CS Plugin Review (Notion) — refer to this document for design intent, Figma references, and measurements.
Changes
Navigation & layout
#2c3337,font-weight: 510#screen-meta-linksand.show-settingsborders unified to#e2e2e4-1pxcompensation for double borderSnippets table
padding-block: 16px,padding-inline: 8pxEditor
h2→h1for page titleposition: staticat ≤782px#c3c4c7viatheme.$control-borderfilemtime()in Edit_Menu.phpBlueprints (Pro)
font-weight: 600, 3-line description clamprepeat(auto-fill, minmax(400px, 1fr))18px/line-height: 1.5Global & accessibility
core,cloud,cloud_search,private)--cs-*CSS custom properties layer in_theme.scssinline-size: max-content,max-inline-size: 200px,12px, dark bgaria-labelandrole="img"filemtime()in Manage_Menu_Assets.php and Settings_Menu.php1.5on card metadata and description textDeferred (follow-up)
QA