-
Notifications
You must be signed in to change notification settings - Fork 112
feat: UI review implementation #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
code-snippets-bot
wants to merge
47
commits into
core-beta
Choose a base branch
from
feat/ui-review/core
base: core-beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 34 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
da1b96e
feat: apply initial UI review tokens
code-snippets-bot 211d1c6
feat: refine snippets navigation
code-snippets-bot 69a4ef9
fix: retain Core tab counts
code-snippets-bot 5ee3624
fix: hide locked tab counts in Core
code-snippets-bot 3924ae3
fix: version Manage assets by build time
code-snippets-bot bd09095
fix: refine settings navigation
code-snippets-bot 99e3aa6
fix: preserve responsive settings access
code-snippets-bot 15ec33e
fix: refine mobile table controls
code-snippets-bot 8c43df6
fix: refine editor sidebar controls
code-snippets-bot e45331e
fix: version editor assets by build time
code-snippets-bot fc44d7e
fix: unify subnavigation bands
code-snippets-bot a8358e9
fix: remove settings tab spacing
code-snippets-bot 74e88de
fix: fill responsive secondary navigation
code-snippets-bot 7bcda6d
fix: normalize card text metrics
code-snippets-bot 3b5d56b
fix: normalize editor controls
code-snippets-bot 34bbdcc
fix: clarify editor heading structure
code-snippets-bot 59ddc51
fix: align shared control variants
code-snippets-bot e966312
fix: unify Pro-only action styling
code-snippets-bot a05ec3c
fix: retain editor heading layout
code-snippets-bot 23e4469
fix: align search field border
code-snippets-bot a40cd43
fix: refine cloud preview controls
code-snippets-bot 52ea778
feat: add snippet search action
code-snippets-bot 1f517fc
fix: show settings navigation overflow
code-snippets-bot 5ada5c3
fix: blend active navigation tab
code-snippets-bot d8de5c1
fix: align navigation and page titles
code-snippets-bot 52b4b02
fix: increase table cell spacing
code-snippets-bot eab2c32
fix: refine table and heading spacing
code-snippets-bot 3b925bf
fix: remove top margin on secondary tabs row
code-snippets-bot 889123b
fix: remove notice margin on nav wrapper
code-snippets-bot 1d4e410
fix: unify border colors and remove container margin
code-snippets-bot c60680b
fix: compensate double border with -1px nav wrapper margin
code-snippets-bot ab09058
fix: adjust badge colours to WCAG AA-compliant values
code-snippets-bot 1de133d
fix: tooltip width fits content
code-snippets-bot 79db211
fix: tooltip width fits content with dark bg
code-snippets-bot cd53178
Merge branch 'core-beta' into feat/ui-review/core
sheabunge 904795d
fix: resolve PR review comments
code-snippets-bot 9f67c68
fix: layer active toolbar link above neighbours
code-snippets-bot 0c343b7
fix: address ramiy's PR review follow-ups
code-snippets-bot 56569f9
fix: upsell page fills content area; remove manage assets filemtime v…
code-snippets-bot 41c4217
fix: hide screen meta links on upsell pages
code-snippets-bot 6c7bc69
fix: consolidate CTA hover colors to #0ca0a9
code-snippets-bot 9703a70
fix: strengthen upsell CTA hover specificity, hide bundles tab header…
code-snippets-bot e8409b7
fix: derive upsell view detection from existing view checks
code-snippets-bot c64550e
fix: match upsell CTA hover border color
code-snippets-bot d905c64
fix: treat bundles tab as upsell view
code-snippets-bot 4f7583c
fix: hide screen meta on bundles tab instead of unmounting
code-snippets-bot 615356e
fix: remove unnecessary wrap class from toolbar container
code-snippets-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to avoid this dependency. We're just using the down chevron – could swap with this? https://developer.wordpress.org/resource/dashicons/#arrow-down-alt2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we should reduce dependencies. If we use specific icons, we can create icon components. We already do that in
src/js/components/common/icons/.