This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Repository navigation
Conversation
Changes:
Total lines: 4769 (+31) |
deployed preview: https://625.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
Anay704
force-pushed
the
route-id-current-segment
branch
from
June 4, 2026 23:49
ccfe04a to
7ac8a4d
Compare
The Route ID now includes the current segment number derived from the timeline/playback position and live-updates as you scrub. Copying the Route ID copies the segment-qualified id as shown. Add a pure getRouteSegment(seekTime, maxSegment) helper that maps a playback time to its segment number, clamped to the route's last segment (maxqlog), with unit tests. Fixes commaai#499
Anay704
force-pushed
the
route-id-current-segment
branch
from
June 4, 2026 23:58
7ac8a4d to
77ac59e
Compare
Author
|
Heads up on CI: the only failing check is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499
The Route ID in the Route Info panel now shows the current segment number, derived from the timeline/playback position, and live-updates as you scrub. Copying the Route ID copies the segment-qualified id as displayed.
Approach
getRouteSegment(seekTime, maxSegment)helper (src/utils/format.ts) that maps a playback time (seconds) to its segment number (60s segments), clamped to the route's last segment viamaxqlog. Unit-tested.seekTimefromRouteActivityintoRouteActionsand derive the segment reactively, so the displayed/copied id updates as the timeline moves.Notes
dongleId/dateStr/segment, matching the existing/-separated Route ID andUploadQueue'sroute/segment. Happy to switch to the canonical--Nsuffix if preferred — one-line change.Testing
getRouteSegmentunit tests,tsc,biome check, and the line/bundle gates all pass./1d3dc3e03047b0c7/000000dd--455f14369d: at playback 3:20 the Route ID reads…455f14369d/3, updating live while scrubbing.