Skip to content

DAOS-19035 test: Genericize Cgo suppressions (#18408)#18435

Open
tanabarr wants to merge 2 commits into
release/2.8from
tanabarr/kjacque/cgo-suppressions-rel2_8
Open

DAOS-19035 test: Genericize Cgo suppressions (#18408)#18435
tanabarr wants to merge 2 commits into
release/2.8from
tanabarr/kjacque/cgo-suppressions-rel2_8

Conversation

@tanabarr
Copy link
Copy Markdown
Contributor

@tanabarr tanabarr commented Jun 4, 2026

  • Update Cgo suppressions with wildcards for the hashes, which can change.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

- Update Cgo suppressions with wildcards for the hashes, which can
  change.

Signed-off-by: Kris Jacque <kris.jacque@hpe.com>
@tanabarr tanabarr requested review from a team as code owners June 4, 2026 12:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Ticket title is 'NLT - Valgrind Memcheck error detected'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-19035

@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label Jun 4, 2026
@tanabarr tanabarr requested review from NiuYawei, kjacque and knard38 June 4, 2026 12:22
@daosbuild3
Copy link
Copy Markdown
Collaborator

kjacque
kjacque previously approved these changes Jun 4, 2026
Copy link
Copy Markdown
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean cherry-pick. Thanks for backporting.

@kjacque
Copy link
Copy Markdown
Contributor

kjacque commented Jun 4, 2026

The NLT failure in CI looks like a different issue:

{
   <insert_a_suppression_name_here>
   Memcheck:Param
   write(buf)
   fun:internal/runtime/syscall/linux.Syscall6
}

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18435/1/testReport/

knard38
knard38 previously approved these changes Jun 5, 2026
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr dismissed stale reviews from knard38 and kjacque via 0448768 June 5, 2026 12:45
@tanabarr tanabarr added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Jun 5, 2026
@tanabarr tanabarr requested review from kjacque and knard38 June 5, 2026 12:47
@daosbuild3
Copy link
Copy Markdown
Collaborator

Comment thread utils/test_memcheck.supp
write(buf)
fun:runtime/internal/syscall.Syscall6
}
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this hurts anything, but the file used by NLT is the cart one. Looks like the latest run had related memcheck issues, including the read variant of this. I think we should land this backport, and address the other issues in another ticket on master, which is also almost certainly affected.

I created one here: https://daosio.atlassian.net/browse/DAOS-19084

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 5, 2026
@tanabarr tanabarr requested a review from a team June 5, 2026 16:15
@tanabarr
Copy link
Copy Markdown
Contributor Author

tanabarr commented Jun 5, 2026

I've requested gatekeeper and forced landing because whilst it still fails NLT it fixes a number of issues, another patch will address more of the suppressions needed.

@daltonbohning
Copy link
Copy Markdown
Contributor

I've requested gatekeeper and forced landing because whilst it still fails NLT it fixes a number of issues, another patch will address more of the suppressions needed.

Which other patch?

@daltonbohning
Copy link
Copy Markdown
Contributor

I've requested gatekeeper and forced landing because whilst it still fails NLT it fixes a number of issues, another patch will address more of the suppressions needed.

Which other patch?

Looks like
https://daosio.atlassian.net/browse/DAOS-19084
#18448

@kjacque
Copy link
Copy Markdown
Contributor

kjacque commented Jun 5, 2026

I've requested gatekeeper and forced landing because whilst it still fails NLT it fixes a number of issues, another patch will address more of the suppressions needed.

Which other patch?

Looks like https://daosio.atlassian.net/browse/DAOS-19084 #18448

Yes, this is the other patch. Different set of suppressions that are also missing on master.

@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18435/2/execution/node/1347/log

@tanabarr
Copy link
Copy Markdown
Contributor Author

tanabarr commented Jun 6, 2026

this can be landed because it only affects NLT so doesn't need to finish hardware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.

Development

Successfully merging this pull request may close these issues.

6 participants