Skip to content

DAOS-19035 test: Genericize Cgo suppressions (#18408) #18435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanabarr wants to merge 2 commits into
base: release/2.8
Choose a base branch
from
+21 −15
Open

DAOS-19035 test: Genericize Cgo suppressions (#18408) #18435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b09aa
DAOS-19035 test: Genericize Cgo suppressions (#18408)
kjacque Jun 4, 2026
0448768
add suppression for syscall warning
tanabarr Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/cart/utils/memcheck-cart.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,11 +558,11 @@
fun:syscall.Syscall.abi0
}
{
DAOS-14680-1
Racecall cgo malloc
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
fun:_cgo_0edd79296193_Cfunc__Cmalloc
fun:_cgo_*_Cfunc__Cmalloc
fun:runtime.asmcgocall.abi0
...
fun:racecall
Expand Down Expand Up @@ -593,16 +593,6 @@
Memcheck:Addr1
fun:racecallatomic
}
{
Go runtime cgo malloc
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
fun:_cgo_b68ed06c1ed7_Cfunc__Cmalloc
fun:runtime.asmcgocall.abi0
...
fun:racecall
}
{
__tsan_go_atomic64_load
Memcheck:Addr8
Expand All @@ -625,15 +615,25 @@
fun:racecall
}
{
DAOS-16052
Persistentalloc cgo malloc
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
fun:_cgo_b68ed06c1ed7_Cfunc__Cmalloc
fun:_cgo_*_Cfunc__Cmalloc
fun:runtime.asmcgocall.abi0
...
fun:runtime.persistentalloc
}
{
Newproc cgo malloc
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
fun:_cgo_*_Cfunc__Cmalloc
fun:runtime.asmcgocall.abi0
...
fun:runtime.newproc.abi0
}
{
__tsan_write_pc
Memcheck:Value8
Expand Down
8 changes: 7 additions & 1 deletion utils/test_memcheck.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,12 @@
write(buf)
fun:runtime/internal/syscall.Syscall6
}
{
Copy link
Copy Markdown
Contributor

@kjacque kjacque Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this hurts anything, but the file used by NLT is the cart one. Looks like the latest run had related memcheck issues, including the read variant of this. I think we should land this backport, and address the other issues in another ticket on master, which is also almost certainly affected.

I created one here: https://daosio.atlassian.net/browse/DAOS-19084

go_runtime_syscall_param_linux
Memcheck:Param
write(buf)
fun:internal/runtime/syscall/linux.Syscall6
}
{
go ShadowSet race
Memcheck:Value8
Expand All @@ -434,7 +440,7 @@
Memcheck:Leak
match-leak-kinds: reachable
fun:malloc
fun:_cgo_b68ed06c1ed7_Cfunc__Cmalloc
fun:_cgo_*_Cfunc__Cmalloc
fun:runtime.asmcgocall.abi0
...
fun:runtime.persistentalloc
Expand Down
Loading