Warning about active blue mapping in colorin#21487
Conversation
If blue_mapping was still switched on from very old edits we at least want a warning.
jenshannoschwalm
added
priority: low
|
The test suite wasn't started until ~2021, by which time it wasn't possible to create sidecars for the suite with that option enabled. When I worked on colorin a few years ago, I didn't find any sidecars with blue mapping enabled, so I stepped very carefully around that code. |
|
Yes i saw that :-) thus i had to do a test version allowing toggling it on/off. I also did a test version enforcing it to be on running the suite, no visibly diffs to me. after that i did the pr :-) |
|
Sorry - i checked again the results of the full suite and there are indeed substancial differences in various tests if i force blue_mapping on (for sure it is not good with the now default late_shot-D65 mode.). So i guess removing it from code might give strange results for some images and we can't really test those. Unfortunately there is something more bad with this test (blue_mapping on for cl and cpu code) It should at least produce identical results - it doesn't and give large differences. I did a quick check on OpenCL code and couldn't spot anything obvious so far ... |
jenshannoschwalm
force-pushed
the
no_blue_mapping_colorin
branch
from
cd74f13 to
5ebef68
Compare
|
I removed the second commit and just left the code that gives at least a warning about those old edits. |
jenshannoschwalm
changed the title
2 participants
Blue mapping warning
If blue_mapping was still switched on from very old edits we at least want a warning.